From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ppc4xx: HCU5 board: add register dump
Date: Wed, 23 Sep 2009 18:49:34 +0200 [thread overview]
Message-ID: <200909231849.34052.sr@denx.de> (raw)
In-Reply-To: <1253719369-26565-1-git-send-email-niklaus.giger@netstal.com>
Hi Niklaus,
On Wednesday 23 September 2009 17:22:47 Niklaus Giger wrote:
> Adds a HCU5 board specific cmd reghcu5 to dump about 140 internal
> register which define the HW configuration. Needed for documentation
> purposes and to compare different settings.
Apart from Peter's comments, I also have a more general comment. Please
correct me if I'm wring, but this register dump doesn't seem to be HCU5
specific, but PPC440EPx specific. If this is the case, we (you) should
probably move this code into the cpu/ppc4xx directory. Perhaps something like:
cpu/ppc4xx/440epx_regdump.c
What do you think?
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
next prev parent reply other threads:[~2009-09-23 16:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-23 15:22 [U-Boot] [PATCH] ppc4xx: HCU5 board: add register dump Niklaus Giger
2009-09-23 15:22 ` [U-Boot] [PATCH] ppc4xx: Update Netstal configs Niklaus Giger
2009-09-23 15:22 ` [U-Boot] [PATCH] ppc4xx: Netstal boards: various cleanups Niklaus Giger
2009-09-23 16:57 ` Stefan Roese
2009-09-23 18:55 ` Wolfgang Denk
2009-09-23 18:50 ` [U-Boot] [PATCH] ppc4xx: Update Netstal configs Wolfgang Denk
2009-09-23 15:59 ` [U-Boot] [PATCH] ppc4xx: HCU5 board: add register dump Peter Tyser
2009-09-24 8:58 ` Niklaus Giger
2009-09-23 16:49 ` Stefan Roese [this message]
2009-09-23 17:51 ` Niklaus Giger
2009-09-24 9:21 ` Stefan Roese
2009-09-24 10:04 ` Peter Tyser
2009-09-24 11:17 ` Stefan Roese
2009-09-23 18:33 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909231849.34052.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox