public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Olof Johansson <olof@lixom.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] OMAP3: Clean up whitespace in mux configs
Date: Sun, 27 Sep 2009 09:33:42 -0500	[thread overview]
Message-ID: <20090927143342.GA7850@lixom.net> (raw)
In-Reply-To: <4ABF2376.5080408@googlemail.com>

On Sun, Sep 27, 2009 at 10:33:58AM +0200, Dirk Behme wrote:
> Olof Johansson wrote:
>> Switch from space-based indentation to tab-based in mux configs, as pointed
>> out by WD at:
>
> You have only two options here: Violate space/tab rule or 80 char rule. 
> We had this discussion with Wolfgang already in the past ;)

Haha, great.

> Last time we had:
>
> ...
> [So Jan 25 2009] [18:50:28] <dirk2>	wdenk: Regarding your code comments 
> in http://lists.denx.de/pipermail/u-boot/2009-January/046090.html:
> [So Jan 25 2009] [18:51:34] <dirk2>	wdenk: Regarding MUX indent:  
> normally yes, but ...
> [So Jan 25 2009] [18:51:59] <wdenk_>	...you have too long lines, then. I 
> know
> [So Jan 25 2009] [18:52:49] <dirk2>	wdenk: ... we tried several  
> formatting options, and jkridner converted one MUX file with beginning  
> TABs. The result wasn't readable better
> [So Jan 25 2009] [18:53:34] <wdenk_>	I'll not fight about this one.
> ...
>
> So last time we stayed with space instead of tab and have 80 char fine.
>
> If we want to switch now to break 80 chars (and this patch does so) but 
> have no spaces any more, I'm fine with it. Just want to give some  
> history.

Heh.

Personally I don't mind the occasional breakage of the 80 character
rule, especially for header files like these that don't affect code
flow readability.

But I don't care either way, I just reformatted it on request. If the
decision goes the other way I can repost the other patch that went on
top of this so it still applies.


-Olof

  parent reply	other threads:[~2009-09-27 14:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-22 22:53 [U-Boot] [PATCH] OMAP3: Clean up whitespace in mux configs Olof Johansson
2009-09-23  0:46 ` Tom
2009-09-26 22:59 ` Tom
2009-09-27  8:33 ` Dirk Behme
2009-09-27 11:56   ` Tom
2009-09-27 14:33   ` Olof Johansson [this message]
2009-09-27 14:25     ` Tom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090927143342.GA7850@lixom.net \
    --to=olof@lixom.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox