From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Mack Date: Mon, 28 Sep 2009 12:04:00 +0200 Subject: [U-Boot] [PATCH] part_dos: check status flags of partitions Message-ID: <20090928100400.GY9361@buzzloop.caiaq.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de The current fatload code has a problem together with the way the DOS partition parser is implemented. This hit me when I tried to load a file from a USB stick which had no partition table but a FAT16 directly written to the first sector. With such an environment, get_partition_info_extended() still finds a valid partition at the first sector since the 0x55aa magic is valid for both the MBR and the FAT boot sector. As a result, part_offset in fs/fat/fat.c is then set to some ridiculous value and the code searching for the directory entry gets lots in an endless loop. The fix is quite simple though - we just need to check the status field of the partitions more stricly. According to the specs, it may only contain 0x00 and 0x80. If get_partition_info() fails for this case, the fatload code falls back to the assumption that there is no partition table and does the right thing then. Please consider applying the following patch. Daniel