public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ppc4xx: Merge PPC4xx DDR and DDR2 ECC handling
Date: Tue, 29 Sep 2009 08:35:31 +0200	[thread overview]
Message-ID: <200909290835.31333.sr@denx.de> (raw)
In-Reply-To: <4AC1A82F.2020006@embedded-sol.com>

Hi Felix,

On Tuesday 29 September 2009 08:24:47 Felix Radensky wrote:
> >> After fixing the problem manually I was able to successfully test
> >> your patch on 405EXr and 460EX boards with ECC.
> >
> > OK, thanks.
> 
> Now that sdram_memsize() is in common DDR2 code I think we can
> get rid of CONFIG_SYS_MBYTES_SDRAM. What do you think ?

Some platform still need it (NAND booting because of the 4k size limitation). 
Others could remove it, but I see no real gain here since those platforms use 
a fixed SDRAM configuration.
 
> Also, my patch has introduced some register definitions to ppc405.h
> which are not needed with your addon patch. Do you want to keep
> them ?

No. I'll remove those in my next patch version. Thanks for the remainder.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

      reply	other threads:[~2009-09-29  6:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-28 16:53 [U-Boot] [PATCH] ppc4xx: Merge PPC4xx DDR and DDR2 ECC handling Stefan Roese
2009-09-28 22:17 ` Felix Radensky
2009-09-29  4:36   ` Stefan Roese
2009-09-29  6:24     ` Felix Radensky
2009-09-29  6:35       ` Stefan Roese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200909290835.31333.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox