From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Tue, 29 Sep 2009 08:35:31 +0200 Subject: [U-Boot] [PATCH] ppc4xx: Merge PPC4xx DDR and DDR2 ECC handling In-Reply-To: <4AC1A82F.2020006@embedded-sol.com> References: <1254156809-10678-1-git-send-email-sr@denx.de> <200909290636.11176.sr@denx.de> <4AC1A82F.2020006@embedded-sol.com> Message-ID: <200909290835.31333.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Felix, On Tuesday 29 September 2009 08:24:47 Felix Radensky wrote: > >> After fixing the problem manually I was able to successfully test > >> your patch on 405EXr and 460EX boards with ECC. > > > > OK, thanks. > > Now that sdram_memsize() is in common DDR2 code I think we can > get rid of CONFIG_SYS_MBYTES_SDRAM. What do you think ? Some platform still need it (NAND booting because of the 4k size limitation). Others could remove it, but I see no real gain here since those platforms use a fixed SDRAM configuration. > Also, my patch has introduced some register definitions to ppc405.h > which are not needed with your addon patch. Do you want to keep > them ? No. I'll remove those in my next patch version. Thanks for the remainder. Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de