From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] TI: DaVinci: GPIO header file and definitions
Date: Wed, 30 Sep 2009 23:47:46 +0200 [thread overview]
Message-ID: <20090930214746.97707832E408@gemini.denx.de> (raw)
In-Reply-To: <0554BEF07D437848AF01B9C9B5F0BC5D92EC0C2F@dlee01.ent.ti.com>
Dear "Paulraj, Sandeep",
In message <0554BEF07D437848AF01B9C9B5F0BC5D92EC0C2F@dlee01.ent.ti.com> you wrote:
>
> > > Why? It is not really important here, but especially when mixing data
> > > types, TABs are preferred, as they will allow for nice vertical
> > > alignment.
> >
> > OK. TABs are preferred.
> >
> > The structure defined below it used a single space.
> > When looked at together, it seemed to me to be inconsistent.
> >
> > Tom
> What do about this patch. You ACK'ed it
> Do you want me to revert to the original patch ?
No. Please leave as is. The difference really is not important here.
I just did not understand why the change was requested in the first
place, but now it has been done, we should not throw even more efforts
on it.
Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Pull the wool over your own eyes!" - J.R. "Bob" Dobbs
next prev parent reply other threads:[~2009-09-30 21:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-29 1:29 [U-Boot] [PATCH] TI: DaVinci: GPIO header file and definitions s-paulraj at ti.com
2009-09-29 12:32 ` Tom
2009-09-30 20:35 ` Wolfgang Denk
2009-09-30 20:56 ` Tom
2009-09-30 21:01 ` Paulraj, Sandeep
2009-09-30 21:47 ` Wolfgang Denk [this message]
2009-09-30 21:48 ` Tom
2009-09-30 21:51 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090930214746.97707832E408@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox