From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ppc4xx: Fix msg "initialization as root-complex failed" upon PCIe scan
Date: Fri, 2 Oct 2009 14:50:19 +0200 [thread overview]
Message-ID: <200910021450.19551.sr@denx.de> (raw)
In-Reply-To: <20091002124158.0CBE8832E408@gemini.denx.de>
Hi Wolfgang,
On Friday 02 October 2009 14:41:58 Wolfgang Denk wrote:
> But looking at this patch, it seems that larger parts in this
> (supposedly) board-specific code are actually more or less identical.
>
> Should we not factor out such common code?
Yes, this could (should) be done. But there are differences in these board
specific functions. This consolidation could introduce new errors/bugs. And I
didn't want to do such a thing, now that the merge window is closed. And
frankly, I don't have the time for such a cleanup right now. But I'll put this
on my to-do list.
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
next prev parent reply other threads:[~2009-10-02 12:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-02 12:35 [U-Boot] [PATCH] ppc4xx: Fix msg "initialization as root-complex failed" upon PCIe scan Stefan Roese
2009-10-02 12:41 ` Wolfgang Denk
2009-10-02 12:50 ` Stefan Roese [this message]
2009-10-03 23:32 ` Wolfgang Denk
2009-10-07 7:33 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910021450.19551.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox