From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Fri, 2 Oct 2009 14:50:19 +0200
Subject: [U-Boot] [PATCH] ppc4xx: Fix msg "initialization as
	root-complex failed" upon PCIe scan
In-Reply-To: <20091002124158.0CBE8832E408@gemini.denx.de>
References: <1254486916-3040-1-git-send-email-sr@denx.de>
	<20091002124158.0CBE8832E408@gemini.denx.de>
Message-ID: <200910021450.19551.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Wolfgang,

On Friday 02 October 2009 14:41:58 Wolfgang Denk wrote:
> But looking at this patch, it seems that larger parts in this
> (supposedly) board-specific code are actually more or less identical.
> 
> Should we not factor out such common code?

Yes, this could (should) be done. But there are differences in these board 
specific functions. This consolidation could introduce new errors/bugs. And I 
didn't want to do such a thing, now that the merge window is closed. And 
frankly, I don't have the time for such a cleanup right now. But I'll put this 
on my to-do list.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de