public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add mpc5125ads board and processor to the mpc512x family
Date: Sun, 04 Oct 2009 17:44:06 +0200	[thread overview]
Message-ID: <20091004154406.B1218832E408@gemini.denx.de> (raw)
In-Reply-To: <20091004102089.SM01140@[206.180.163.89]>

Dear Martha,

umm... your mail header still says "m marx".

In message <20091004102089.SM01140@[206.180.163.89]> you wrote:
> 
> I am planning to resubmit this patch very soon - by Tuesday perhaps.
> Considering there is some differences in the memory layout esp for the
> iopin struct (going from 32-bit to byte sizes)  I am not sure how I can
> get around the #defs you suggest.  Perhaps an entirely separate .c file
> for this part ??  

This depends on the situation. If the struct layout is absolutely
identical, just with different datatypes, we might use a #defined type
in the sruct. If not (which seems to be the case almost everywhere
where I looked), then we have to use at least different structs.

> Much of what you pointed to was copied over from the mpc5121ads ... so I
> didn't pay that much attention.  I will fix these too and also fix the
> 5121 code later.

Not paying much attention is always a bad thing which adds avoidable
efforts.

> When do you need it so I can give you enough time to look it over?

It depends. If you want to see this go in for the current release, we
should have clean and stable code in a week or two. Of head for the
next release, then ther eis no hurry at all.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Unix: Some say the learning curve is steep,  but  you  only  have  to
climb it once.                                      - Karl Lehenbauer

  reply	other threads:[~2009-10-04 15:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-04 14:20 [U-Boot] [PATCH] Add mpc5125ads board and processor to the mpc512x family m marx
2009-10-04 15:44 ` Wolfgang Denk [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-10-20 13:53 m stan
2009-10-20 20:57 ` Wolfgang Denk
2009-10-13 17:45 m stan
2009-10-18 19:46 ` Wolfgang Denk
2009-10-19 22:45   ` John Rigby
2009-10-20 21:58     ` Wolfgang Denk
2009-10-21 15:20     ` Kenneth Johansson
2009-10-08  7:40 Martha Stan
2009-10-13 10:02 ` Wolfgang Denk
2009-09-21 20:27 Martha M Stan
2009-09-21 21:09 ` Fabio Estevam
2009-10-03 22:43 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091004154406.B1218832E408@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox