From: Simon Kagstrom <simon.kagstrom@netinsight.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm926ejs: 16-byte align stack to avoid LDRD/STRD problems
Date: Mon, 5 Oct 2009 16:40:54 +0200 [thread overview]
Message-ID: <20091005164054.41ac993c@marrow.netinsight.se> (raw)
In-Reply-To: <c166aa9f0910050730y3d562a44lc58a622e5e084164@mail.gmail.com>
On Mon, 5 Oct 2009 09:30:54 -0500
Andrew Dyer <amdyer@gmail.com> wrote:
> > ? ? ? ?sub ? ? r0, r0, #(CONFIG_STACKSIZE_IRQ+CONFIG_STACKSIZE_FIQ)
> > ?#endif
> > - ? ? ? sub ? ? sp, r0, #12 ? ? ? ? ? ? /* leave 3 words for abort-stack ? ?*/
> > + ? ? ? sub ? ? sp, r0, #16 ? ? ? ? ? ? /* leave 3 words for abort-stack and */
> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? /* align stack for ldrd/strd */
>
> This doesn't guarantee an alignment. Right above this code is a
> series of subtractions by constants, any one of which could throw the
> alignment out of whack and be difficult to figure out.
>
> IMHO it's much safer to do the subtraction to R0, then mask the bottom
> address bits out to guarantee alignment, then stuff the results into
> sp.
Right, new patch coming up.
Thanks,
// Simon
prev parent reply other threads:[~2009-10-05 14:40 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-29 13:55 [U-Boot] kirkwood (openrd): saveenv will not work with environment in NAND Dieter Kiermaier
2009-09-29 15:16 ` Dieter Kiermaier
2009-09-30 6:21 ` Simon Kagstrom
2009-09-30 7:02 ` Dieter Kiermaier
2009-09-30 7:08 ` Simon Kagstrom
2009-09-30 7:40 ` Dieter Kiermaier
2009-09-30 7:57 ` Simon Kagstrom
2009-09-30 8:15 ` Dieter Kiermaier
2009-09-30 8:17 ` Simon Kagstrom
2009-09-30 8:25 ` Dieter Kiermaier
2009-09-30 9:28 ` [U-Boot] Flash sanity checks Prafulla Wadaskar
2009-09-30 9:58 ` Dieter Kiermaier
2009-09-30 12:19 ` Stefan Roese
2009-10-06 17:16 ` [U-Boot] kirkwood (openrd): saveenv will not work with environment in NAND Prafulla Wadaskar
2009-09-30 20:32 ` Wolfgang Denk
2009-10-01 7:29 ` [U-Boot] [PATCH] Make arm926ejs use -mabi=apcs-gnu to avoid EABI problems Simon Kagstrom
2009-10-01 9:56 ` Prafulla Wadaskar
2009-10-01 18:27 ` Wolfgang Denk
2009-10-02 14:44 ` Simon Kagstrom
2009-10-05 13:23 ` [U-Boot] [PATCH] arm926ejs: 16-byte align stack to avoid LDRD/STRD problems Simon Kagstrom
2009-10-05 14:30 ` Andrew Dyer
2009-10-05 14:35 ` Stefan Roese
2009-10-05 14:53 ` [U-Boot] [PATCH v2] " Simon Kagstrom
2009-10-05 15:44 ` Dieter Kiermaier
2009-10-05 18:37 ` Tom
2009-10-06 7:07 ` Simon Kagstrom
2009-10-05 22:07 ` Måns Rullgård
2009-10-06 4:13 ` Prafulla Wadaskar
2009-10-06 6:44 ` [U-Boot] [PATCH v3] arm926ejs: 8-byte " Simon Kagstrom
2009-10-06 16:50 ` Tom
2009-10-18 2:15 ` Tom
2009-10-05 14:40 ` Simon Kagstrom [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091005164054.41ac993c@marrow.netinsight.se \
--to=simon.kagstrom@netinsight.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox