From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Wed, 7 Oct 2009 09:34:41 +0200 Subject: [U-Boot] [PATCH 1/4] ppc4xx: Cleanup some HW register names In-Reply-To: <200910041739.04371.niklaus.giger@member.fsf.org> References: <1254507131-32670-1-git-send-email-niklaus.giger@member.fsf.org> <200910041336.25263.sr@denx.de> <200910041739.04371.niklaus.giger@member.fsf.org> Message-ID: <200910070934.41363.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Niklaus, On Sunday 04 October 2009 17:39:04 Niklaus Giger wrote: > > > +++ b/include/ppc405.h > > > @@ -578,7 +578,7 @@ > > > #define IICEXTSTS 0x09 > > > #define IICLSADR 0x0A > > > #define IICHSADR 0x0B > > > -#define IICCLKDIV 0x0C > > > +#define IIC0_CLKDIV 0x0C > > > #define IICINTRMSK 0x0D > > > #define IICXFRCNT 0x0E > > > #define IICXTCNTLSS 0x0F > > > > Why did you "only" change one of there I2C defines? Not enough time to > > change them all? Any chance that you could change the other defines as > > well? Or remove them if they are not used at all. > > Yes. No enough time and they would need cleaning up even more files. > Please let the patch without requiring to change these definitions too. I > will try to devote some time to them later on. OK, I'll add your v2 patches now, since it's definitely an improvement. Looking forward to further updates... ;) Thanks. Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de