From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3 1/3] lib_generic memcpy: copy one word at a time if possible
Date: Fri, 9 Oct 2009 06:21:08 -0400 [thread overview]
Message-ID: <200910090621.10386.vapier@gentoo.org> (raw)
In-Reply-To: <20091009091220.GA3801@mail.gnudd.com>
On Friday 09 October 2009 05:12:20 Alessandro Rubini wrote:
> + /* while all data is aligned (common case), copy a word at a time */
> + if ( (((ulong)dest | (ulong)src | count) & (sizeof(*dl) - 1)) == 0) {
i think you want to drop the count from the list, otherwise we dont consume
the leading groups of 4 bytes if count isnt a multiple of 4.
otherwise, it's pretty crazy how generic yet optimized the resulting C should
be :). acked-by-me.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091009/cef8f0d0/attachment.pgp
next prev parent reply other threads:[~2009-10-09 10:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-09 9:12 [U-Boot] [PATCH V3 1/3] lib_generic memcpy: copy one word at a time if possible Alessandro Rubini
2009-10-09 10:21 ` Mike Frysinger [this message]
2009-10-09 10:50 ` Alessandro Rubini
2009-10-10 6:13 ` Chris Moore
2009-10-10 7:44 ` Alessandro Rubini
2009-10-12 4:37 ` Chris Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910090621.10386.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox