From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mem_mtest: fix error reporting, allow escape with ^C
Date: Sun, 18 Oct 2009 22:57:17 +0200 [thread overview]
Message-ID: <20091018205717.8FBDF3F6CE@gemini.denx.de> (raw)
In-Reply-To: <1254521913-25655-1-git-send-email-paul.gortmaker@windriver.com>
Dear Paul Gortmaker,
In message <1254521913-25655-1-git-send-email-paul.gortmaker@windriver.com> you wrote:
> The basic memtest function tries to watch for ^C after each
> pattern pass as an escape mechanism, but if things are horribly
> wrong, we'll be stuck in an inner loop flooding the console with
> error messages and never check for ^C. To make matters worse,
> if the user waits for all the error messages to complete, we
> then incorrectly report the test passed without errors.
>
> Adding a check for ^C after any error is printed will give
> the end user an escape mechanism from a console flood without
> slowing down the overall test speed on a slow processor.
>
> Also, the more extensive memtest quit after just a single error,
> which is inconsistent with the normal memtest, and not useful if
> if you are doing dynamic environmental impact testing, such as
> heating/cooling etc.
>
> Both tests now track the error count and report it properly
> at test completion.
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
>
> Changes: fixed return values since prev. version.
>
> common/cmd_mem.c | 58 ++++++++++++++++++++++++++++++++++++++++-------------
> 1 files changed, 44 insertions(+), 14 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Bus error -- please leave by the rear door.
prev parent reply other threads:[~2009-10-18 20:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 19:21 [U-Boot] [PATCH] mem_mtest: bail out after finding 1st memory error Paul Gortmaker
2009-09-30 20:23 ` Wolfgang Denk
2009-09-30 20:53 ` Paul Gortmaker
2009-09-30 21:46 ` Wolfgang Denk
2009-10-01 14:00 ` Paul Gortmaker
2009-10-01 18:33 ` Wolfgang Denk
2009-10-01 23:52 ` [U-Boot] [PATCH] mem_mtest: fix error reporting, allow escape with ^C Paul Gortmaker
2009-10-01 23:57 ` Mike Frysinger
2009-10-02 0:04 ` Paul Gortmaker
2009-10-02 22:18 ` Paul Gortmaker
2009-10-03 6:19 ` Mike Frysinger
2009-10-18 20:57 ` Wolfgang Denk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091018205717.8FBDF3F6CE@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox