From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] setenv: do console redirection even if previously unset
Date: Sun, 18 Oct 2009 23:07:14 +0200 [thread overview]
Message-ID: <20091018210714.301FD3F6CE@gemini.denx.de> (raw)
In-Reply-To: <20091008122914.GA4674@mail.gnudd.com>
Dear Alessandro Rubini,
In message <20091008122914.GA4674@mail.gnudd.com> you wrote:
> From: Alessandro Rubini <rubini@unipv.it>
>
> If "stdout" is not previously set, doing "setenv stdout lcd" had no
> effect, since console redirection only worked if the environment
> variable was already set; the second time you run setenv it worked.
> Most default environments lack stdin/out/err definitions, so I'm sure
> I'm not alone with this problem.
>
> This patch simply moves a block of code out of a conditional, to do
> the same work even if the variable was previously unset.
>
> Signed-off-by: Alessandro Rubini <rubini@unipv.it>
> Acked-by: Andrea Gallo <andrea.gallo@stericsson.com>
> ---
> common/cmd_nvedit.c | 62 +++++++++++++++++++++++++-------------------------
> 1 files changed, 31 insertions(+), 31 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Our business is run on trust. We trust you will pay in advance.
prev parent reply other threads:[~2009-10-18 21:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-08 12:29 [U-Boot] [PATCH] setenv: do console redirection even if previously unset Alessandro Rubini
2009-10-18 21:07 ` Wolfgang Denk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091018210714.301FD3F6CE@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox