From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Sun, 18 Oct 2009 23:07:14 +0200 Subject: [U-Boot] [PATCH] setenv: do console redirection even if previously unset In-Reply-To: <20091008122914.GA4674@mail.gnudd.com> References: <20091008122914.GA4674@mail.gnudd.com> Message-ID: <20091018210714.301FD3F6CE@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Alessandro Rubini, In message <20091008122914.GA4674@mail.gnudd.com> you wrote: > From: Alessandro Rubini > > If "stdout" is not previously set, doing "setenv stdout lcd" had no > effect, since console redirection only worked if the environment > variable was already set; the second time you run setenv it worked. > Most default environments lack stdin/out/err definitions, so I'm sure > I'm not alone with this problem. > > This patch simply moves a block of code out of a conditional, to do > the same work even if the variable was previously unset. > > Signed-off-by: Alessandro Rubini > Acked-by: Andrea Gallo > --- > common/cmd_nvedit.c | 62 +++++++++++++++++++++++++------------------------- > 1 files changed, 31 insertions(+), 31 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Our business is run on trust. We trust you will pay in advance.