public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] tools: Use override when changing CC, CFLAGS, etc.
Date: Tue, 20 Oct 2009 00:35:14 +0200	[thread overview]
Message-ID: <20091019223514.7CC65C88C5@gemini.denx.de> (raw)
In-Reply-To: <20091019212435.GA31339@loki.buserror.net>

Dear Scott Wood,

In message <20091019212435.GA31339@loki.buserror.net> you wrote:
> If the user has specified a CC or similar on the command line, that is the
> cross compiler, not the host compiler.  Override is needed to keep these
> assignments from being ignored in that case.
> 
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> ---
>  tools/Makefile     |   10 +++++-----
>  tools/gdb/Makefile |    6 +++---
>  2 files changed, 8 insertions(+), 8 deletions(-)

As Mike pointed out, we should rather consistently use HOSTCC when we
refer to the host's C compiler.

I suggest you rework the patch to do that.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Swap read error.  You lose your mind.

      parent reply	other threads:[~2009-10-19 22:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-19 21:24 [U-Boot] [PATCH 2/2] tools: Use override when changing CC, CFLAGS, etc Scott Wood
2009-10-19 21:42 ` Mike Frysinger
2009-10-19 21:56   ` Scott Wood
2009-10-19 22:37     ` [U-Boot] [PATCH 2/2] tools: Use override when changing CC, CFLAGS , etc Mike Frysinger
2009-10-20 21:53   ` [U-Boot] [PATCH 2/2] tools: Use override when changing CC, CFLAGS, etc Scott Wood
2009-10-21  1:17     ` [U-Boot] [PATCH 2/2] tools: Use override when changing CC, CFLAGS , etc Mike Frysinger
2009-10-19 22:35 ` Wolfgang Denk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091019223514.7CC65C88C5@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox