public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/5] Check for NULL prompt in readline_into_buffer()
Date: Sun, 25 Oct 2009 00:00:22 +0200	[thread overview]
Message-ID: <20091024220022.2A864185D4AA@gemini.denx.de> (raw)
In-Reply-To: <4AE37708.7050704@xes-inc.com>

Dear Peter Tyser,

In message <4AE37708.7050704@xes-inc.com> you wrote:
>
> > I don't want to debate these. Actually I like the code.
> 
> Fantastic!

Indeed :-)

> > And if you
> > could be so kind and write a little more about this background
> > information in the commit messages, I'm really tempted to pull this
> > in ASAP :-)
> 
> OK.  Let me know which patch commit messages should be improved and I'll 
> resubmit.

Well, just look at my questions. Add the explanations you  just  sent
in  the  mails  (prepare the code for adding the editenv command...),
and everybody understands the context.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
... Jesus cried with a loud voice: Lazarus, come forth; the bug  hath
been  found  and  thy  program  runneth.  And  he  that was dead came
forth...                              -- John 11:43-44 [version 2.0?]

      reply	other threads:[~2009-10-24 22:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-23  0:59 [U-Boot] [PATCH 1/5] Check for NULL prompt in readline_into_buffer() Peter Tyser
2009-10-23  0:59 ` [U-Boot] [PATCH 2/5] cread_line(): Remove unused variables Peter Tyser
2009-10-23  0:59 ` [U-Boot] [PATCH 3/5] readline(): Add ability to modify a string buffer Peter Tyser
2009-10-24 17:26   ` Wolfgang Denk
2009-10-24 21:47     ` Peter Tyser
2009-10-25  5:32       ` Mike Frysinger
2009-10-23  0:59 ` [U-Boot] [PATCH 4/5] _do_setenv(): Delete 0-length environment variables Peter Tyser
2009-10-23  0:59 ` [U-Boot] [PATCH 5/5] Add 'editenv' command Peter Tyser
2009-10-24 17:23 ` [U-Boot] [PATCH 1/5] Check for NULL prompt in readline_into_buffer() Wolfgang Denk
2009-10-24 21:37   ` Peter Tyser
2009-10-24 21:47     ` Wolfgang Denk
2009-10-24 21:52       ` Peter Tyser
2009-10-24 22:00         ` Wolfgang Denk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091024220022.2A864185D4AA@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox