From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/5] readline(): Add ability to modify a string buffer
Date: Sun, 25 Oct 2009 01:32:26 -0400 [thread overview]
Message-ID: <200910250132.28174.vapier@gentoo.org> (raw)
In-Reply-To: <4AE375EF.7060401@xes-inc.com>
On Saturday 24 October 2009 17:47:27 Peter Tyser wrote:
> Wolfgang Denk wrote:
> > Peter Tyser wrote:
> >> If the 'buf' parameter is a non-0-length string, its contents will be
> >> edited. Previously, the initial value of 'buf' was ignored and the
> >> user entered its contents from scratch.
> >
> > What is the purpose of this modification? Are you fixing a bug (which
> > one?) or implementing an extension (which one) or what?
>
> This change was necessary to add a new "editenv" command. This change
> allows the readline() function to edit a string instead of just enter
> one from scratch. In theory this feature could be used for other areas
> of U-Boot in the future, but at this point the only user of it would be
> the "editenv" command which I submitted a patch for. If the 'editenv'
> patch is rejected, I don't mind this one being rejected too.
+1 from me for new "editenv" :)
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091025/9679bbec/attachment.pgp
next prev parent reply other threads:[~2009-10-25 5:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-23 0:59 [U-Boot] [PATCH 1/5] Check for NULL prompt in readline_into_buffer() Peter Tyser
2009-10-23 0:59 ` [U-Boot] [PATCH 2/5] cread_line(): Remove unused variables Peter Tyser
2009-10-23 0:59 ` [U-Boot] [PATCH 3/5] readline(): Add ability to modify a string buffer Peter Tyser
2009-10-24 17:26 ` Wolfgang Denk
2009-10-24 21:47 ` Peter Tyser
2009-10-25 5:32 ` Mike Frysinger [this message]
2009-10-23 0:59 ` [U-Boot] [PATCH 4/5] _do_setenv(): Delete 0-length environment variables Peter Tyser
2009-10-23 0:59 ` [U-Boot] [PATCH 5/5] Add 'editenv' command Peter Tyser
2009-10-24 17:23 ` [U-Boot] [PATCH 1/5] Check for NULL prompt in readline_into_buffer() Wolfgang Denk
2009-10-24 21:37 ` Peter Tyser
2009-10-24 21:47 ` Wolfgang Denk
2009-10-24 21:52 ` Peter Tyser
2009-10-24 22:00 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910250132.28174.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox