[U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed

[Mike Frysinger <vapier@gentoo.org>]

On Monday 26 October 2009 08:13:57 Stefan Roese wrote:
> On Monday 26 October 2009 09:36:11 Mike Frysinger wrote:
> > > But when I remove the CONFIG_ENV_IS_EMBEDDED definition from line 127
> > > of include/configs/kilauea.h, then I get this:
> > >
> > > 	./MAKEALL kilauea kilauea_nand
> > > 	Configuring for kilauea board...
> > > 	   text    data     bss     dec     hex filename
> > > 	 287816   24656   46548  359020   57a6c /work/wd/tmp-ppc/u-boot
> > > 	Configuring for kilauea_nand board...
> > > 	ppc_6xx-ld: cannot find common/env_embedded.o
> > > 	make: *** [/work/wd/tmp-ppc/u-boot] Error 1
> > >
> > > There seems to be still a logic error ...
> >
> > should be harmless, but obviously it's ugly.  the attached patch should
> > fix things up.  the related issue is the one i raised in the other env
> > embedded thread wrt the meaning of "ENV_IS_EMBEDDED" ...
> 
> Thanks. With this patch, most of the ppc4xx compile problems I have noticed
> are gone now. But unfortunately not all. Those two 4xx platforms still
>  don't compile:
> 
> CRAYL1 EXBITGEN
> 
> $ ./MAKEALL CRAYL1
> Configuring for CRAYL1 board...
> ppc_4xx-ld: cannot find common/env_embedded.o
> make: *** [u-boot] Error 1
> ppc_4xx-size: './u-boot': No such file
> 
> A quick scan reveals that both ports have one thing in common. They both
> include:
>   common/env_embedded.o(.text)
> in their linker scripts.

you sure you applied the patch fully ?  in the patch i posted:
 board/cray/L1/u-boot.lds             |    3 ---
 board/cray/L1/u-boot.lds.debug       |    2 --
 board/exbitgen/u-boot.lds            |    3 ---
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091026/7c8d1a83/attachment.pgp