public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed
Date: Mon, 26 Oct 2009 14:13:57 +0200	[thread overview]
Message-ID: <200910261313.57922.sr@denx.de> (raw)
In-Reply-To: <200910260436.12814.vapier@gentoo.org>

On Monday 26 October 2009 09:36:11 Mike Frysinger wrote:
> > But when I remove the CONFIG_ENV_IS_EMBEDDED definition from line 127
> > of include/configs/kilauea.h, then I get this:
> >
> > 	./MAKEALL kilauea kilauea_nand
> > 	Configuring for kilauea board...
> > 	   text    data     bss     dec     hex filename
> > 	 287816   24656   46548  359020   57a6c /work/wd/tmp-ppc/u-boot
> > 	Configuring for kilauea_nand board...
> > 	ppc_6xx-ld: cannot find common/env_embedded.o
> > 	make: *** [/work/wd/tmp-ppc/u-boot] Error 1
> >
> > There seems to be still a logic error ...
> 
> should be harmless, but obviously it's ugly.  the attached patch should fix
> things up.  the related issue is the one i raised in the other env embedded
> thread wrt the meaning of "ENV_IS_EMBEDDED" ...

Thanks. With this patch, most of the ppc4xx compile problems I have noticed 
are gone now. But unfortunately not all. Those two 4xx platforms still don't 
compile:

CRAYL1 EXBITGEN

$ ./MAKEALL CRAYL1
Configuring for CRAYL1 board...
ppc_4xx-ld: cannot find common/env_embedded.o
make: *** [u-boot] Error 1
ppc_4xx-size: './u-boot': No such file

A quick scan reveals that both ports have one thing in common. They both 
include:
  common/env_embedded.o(.text)
in their linker scripts.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

  reply	other threads:[~2009-10-26 12:13 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-27  8:31 [U-Boot] [PATCH/RFC] env: always build env_embedded and envcrc Mike Frysinger
2009-07-27 20:52 ` Wolfgang Denk
2009-09-09 12:14 ` [U-Boot] [PATCH v2] env: only build env_embedded and envcrc when needed Mike Frysinger
2009-09-09 13:33   ` Wolfgang Denk
2009-09-09 14:02     ` Mike Frysinger
2009-09-09 14:26       ` Wolfgang Denk
2009-09-09 14:32         ` Mike Frysinger
2009-09-15 20:44           ` Wolfgang Denk
2009-09-15 21:39             ` Mike Frysinger
2009-09-22 20:43               ` Wolfgang Denk
2009-09-23 15:40                 ` Mike Frysinger
2009-09-09 15:50   ` [U-Boot] [PATCH 1/2 v3] " Mike Frysinger
2009-09-15 20:45     ` Wolfgang Denk
2009-09-09 15:50   ` [U-Boot] [PATCH 2/2] Blackfin: tweak embedded env config option Mike Frysinger
2009-09-11  9:39     ` [U-Boot] [PATCH 2/2 v2] " Mike Frysinger
2009-09-15 20:49       ` Wolfgang Denk
2009-09-15 21:36         ` Mike Frysinger
2009-09-22 20:41           ` Wolfgang Denk
2009-09-23 15:41             ` Mike Frysinger
2009-10-01  7:12         ` Mike Frysinger
2009-09-30 19:29   ` [U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed Mike Frysinger
2009-10-18 20:53     ` Wolfgang Denk
2009-10-18 21:01       ` Mike Frysinger
2009-10-18 21:19         ` Wolfgang Denk
2009-10-18 21:32         ` Wolfgang Denk
2009-10-18 21:51           ` Mike Frysinger
2009-10-18 21:58             ` Wolfgang Denk
2009-10-19  0:55           ` Mike Frysinger
2009-10-19  9:31             ` Wolfgang Denk
2009-10-19 19:36               ` Mike Frysinger
2009-10-25 20:14             ` Wolfgang Denk
2009-10-25 21:55             ` Wolfgang Denk
2009-10-26  8:36               ` Mike Frysinger
2009-10-26 12:13                 ` Stefan Roese [this message]
2009-10-26 12:26                   ` Mike Frysinger
2009-10-26 12:34                     ` Stefan Roese
2009-10-26 20:45                       ` Mike Frysinger
2009-10-26 19:17                 ` Wolfgang Denk
2009-10-26 20:43                   ` Mike Frysinger
2009-10-26 23:24             ` Wolfgang Denk
2009-09-30 19:29   ` [U-Boot] [PATCH 2/2 v3] Blackfin: tweak embedded LDR env config option Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200910261313.57922.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox