From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Mon, 26 Oct 2009 14:13:57 +0200 Subject: [U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed In-Reply-To: <200910260436.12814.vapier@gentoo.org> References: <1252498455-28276-1-git-send-email-vapier@gentoo.org> <20091025215508.125A8E916D5@gemini.denx.de> <200910260436.12814.vapier@gentoo.org> Message-ID: <200910261313.57922.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday 26 October 2009 09:36:11 Mike Frysinger wrote: > > But when I remove the CONFIG_ENV_IS_EMBEDDED definition from line 127 > > of include/configs/kilauea.h, then I get this: > > > > ./MAKEALL kilauea kilauea_nand > > Configuring for kilauea board... > > text data bss dec hex filename > > 287816 24656 46548 359020 57a6c /work/wd/tmp-ppc/u-boot > > Configuring for kilauea_nand board... > > ppc_6xx-ld: cannot find common/env_embedded.o > > make: *** [/work/wd/tmp-ppc/u-boot] Error 1 > > > > There seems to be still a logic error ... > > should be harmless, but obviously it's ugly. the attached patch should fix > things up. the related issue is the one i raised in the other env embedded > thread wrt the meaning of "ENV_IS_EMBEDDED" ... Thanks. With this patch, most of the ppc4xx compile problems I have noticed are gone now. But unfortunately not all. Those two 4xx platforms still don't compile: CRAYL1 EXBITGEN $ ./MAKEALL CRAYL1 Configuring for CRAYL1 board... ppc_4xx-ld: cannot find common/env_embedded.o make: *** [u-boot] Error 1 ppc_4xx-size: './u-boot': No such file A quick scan reveals that both ports have one thing in common. They both include: common/env_embedded.o(.text) in their linker scripts. Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de