From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] davinci timer.c: Remove volatiles and memory mapped structures
Date: Mon, 26 Oct 2009 16:48:05 +0200 [thread overview]
Message-ID: <200910261548.05192.sr@denx.de> (raw)
In-Reply-To: <1256568176.11916.3052.camel@localhost.localdomain>
On Monday 26 October 2009 15:42:56 Peter Tyser wrote:
> > +++ b/cpu/arm926ejs/davinci/timer.c
> > @@ -1,4 +1,8 @@
> > /*
> > + * Copyright (C) 2009 Nick Thompson, GE Fanuc, Ltd.
> > <nick.thompson@gefanuc.com> + *
> > + * Coding style changes. Use writel and readl for hardware accesses.
> > + *
> > * (C) Copyright 2003
> > * Texas Instruments <www.ti.com>
> > *
>
> The change looks good to me, but I don't think your copyright should be
> added for such a trivial change. There are already 6 separate
> copyrights for a relatively simple 100 lines of code:)
And you shouldn't add such comments about what you changed into the file
itself. git will handle those comments.
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
prev parent reply other threads:[~2009-10-26 14:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 14:28 [U-Boot] [PATCH] davinci timer.c: Remove volatiles and memory mapped structures Nick Thompson
2009-10-26 14:42 ` Peter Tyser
2009-10-26 14:48 ` Stefan Roese [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910261548.05192.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox