From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Make the generic unaligned access code safe for unaligned access
Date: Thu, 29 Oct 2009 07:01:11 +0200 [thread overview]
Message-ID: <200910290601.11199.sr@denx.de> (raw)
In-Reply-To: <1256764421-27799-4-git-send-email-linux@bohmer.net>
Hi Remy,
On Wednesday 28 October 2009 22:13:38 Remy Bohmer wrote:
> The current generic code for handling unaligned access assumes that
> the processor can properly handle unaligned accesses itself.
> This is at least not the case for ARM, which results in runtime
> errors.
>
> Rewrite it such that it works for ARM as well.
I introduced this header some time ago for UBIFS support (for PowerPC).
As you may have noticed, it's a copy from the Linux version. And I
would like to keep it this way if possible. Looking at the Linux ARM
version, the basic difference seems to be the header
"include/asm-arm/unaligned.h" which includes this file. The Linux
version of "unaligned.h" does *not* include "access_ok.h" at all. It
includes "le_byteshift.h" and "be_byteshift.h" instead. And I would
really like to keep this in sync with Linux if possible.
So why not do it this way (totally untested):
next prev parent reply other threads:[~2009-10-29 5:01 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-28 21:13 [U-Boot] [PATCH] Building of FIT images does not work Remy Bohmer
2009-10-28 21:13 ` [U-Boot] [PATCH] Fix mingw tools build Remy Bohmer
2009-10-28 21:13 ` [U-Boot] [PATCH] Add support for CS2 dataflash for Atmel-SPI Remy Bohmer
2009-10-28 21:13 ` [U-Boot] [PATCH] Make the generic unaligned access code safe for unaligned access Remy Bohmer
2009-10-28 21:13 ` [U-Boot] [PATCH] Repair the 'netry=once' option Remy Bohmer
2009-10-28 21:13 ` [U-Boot] [PATCH] Add error codes/handling for TFTP-server Remy Bohmer
2009-10-28 21:13 ` [U-Boot] [PATCH] Repair build failure in case PPC is not defined and FIT is beng used Remy Bohmer
2009-10-29 10:53 ` Wolfgang Denk
2009-10-29 11:35 ` Remy Bohmer
2009-10-29 12:36 ` Wolfgang Denk
2009-11-10 6:30 ` [U-Boot] [PATCH] Add error codes/handling for TFTP-server Ben Warren
2009-11-10 6:28 ` [U-Boot] [PATCH] Repair the 'netry=once' option Ben Warren
2009-11-23 22:48 ` Wolfgang Denk
2009-10-29 5:01 ` Stefan Roese [this message]
2009-10-29 11:24 ` [U-Boot] [PATCH] Make the generic unaligned access code safe for unaligned access Remy Bohmer
2009-10-29 14:30 ` Tom
2009-10-29 14:34 ` Remy Bohmer
2009-10-29 15:17 ` Tom
2009-10-29 15:34 ` Remy Bohmer
2009-10-29 15:40 ` Stefan Roese
2009-10-29 17:51 ` Tom
2009-11-23 22:46 ` Wolfgang Denk
2009-11-24 4:05 ` Stefan Roese
2009-11-24 10:07 ` Remy Bohmer
2009-11-24 21:41 ` Wolfgang Denk
2009-11-23 22:44 ` [U-Boot] [PATCH] Add support for CS2 dataflash for Atmel-SPI Wolfgang Denk
2009-11-23 22:43 ` [U-Boot] [PATCH] Fix mingw tools build Wolfgang Denk
2009-11-23 22:43 ` [U-Boot] [PATCH] Building of FIT images does not work Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910290601.11199.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox