public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Repair build failure in case PPC is not defined and FIT is beng used.
Date: Thu, 29 Oct 2009 11:53:17 +0100	[thread overview]
Message-ID: <20091029105317.DA7A419F73@gemini.denx.de> (raw)
In-Reply-To: <1256764421-27799-7-git-send-email-linux@bohmer.net>

Dear Remy Bohmer,

please pay a little more attention to the commit subjects (here:
s/beng/being/, please); also, make sure the subject is short enough
for a commit message title line.

In message <1256764421-27799-7-git-send-email-linux@bohmer.net> you wrote:
> Signed-off-by: Remy Bohmer <linux@bohmer.net>
> ---
>  common/cmd_bootm.c |    2 +-
>  common/image.c     |    2 ++
>  2 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
> index 8f83598..32fd9bb 100644
> --- a/common/cmd_bootm.c
> +++ b/common/cmd_bootm.c
> @@ -524,7 +524,7 @@ int do_bootm_subcommand (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
>  		}
>  			break;
>  #endif
> -#ifdef CONFIG_OF_LIBFDT
> +#if defined(CONFIG_OF_LIBFDT) && defined(CONFIG_SYS_BOOTMAPSZ)
>  		case BOOTM_STATE_FDT:
>  		{
>  			ulong bootmap_base = getenv_bootm_low();
> diff --git a/common/image.c b/common/image.c
> index 6eaf41e..41b584d 100644
> --- a/common/image.c
> +++ b/common/image.c
> @@ -1506,9 +1506,11 @@ int boot_get_fdt (int flag, int argc, char *argv[], bootm_headers_t *images,
>  					fdt_blob = (char *)data;
>  				}
>  
> +#if defined(CONFIG_PPC)
>  				images->fit_hdr_fdt = fit_hdr;
>  				images->fit_uname_fdt = fit_uname_fdt;
>  				images->fit_noffset_fdt = fdt_noffset;
> +#endif

NAK. This code is in no way dependent on the Power architecture, so
CONFIG_PPC is definitly the wrong thing to check for.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The years of peak mental activity are undoubtedly between the ages of
four and eighteen. At four we know all the questions, at eighteen all
the answers.

  reply	other threads:[~2009-10-29 10:53 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-28 21:13 [U-Boot] [PATCH] Building of FIT images does not work Remy Bohmer
2009-10-28 21:13 ` [U-Boot] [PATCH] Fix mingw tools build Remy Bohmer
2009-10-28 21:13   ` [U-Boot] [PATCH] Add support for CS2 dataflash for Atmel-SPI Remy Bohmer
2009-10-28 21:13     ` [U-Boot] [PATCH] Make the generic unaligned access code safe for unaligned access Remy Bohmer
2009-10-28 21:13       ` [U-Boot] [PATCH] Repair the 'netry=once' option Remy Bohmer
2009-10-28 21:13         ` [U-Boot] [PATCH] Add error codes/handling for TFTP-server Remy Bohmer
2009-10-28 21:13           ` [U-Boot] [PATCH] Repair build failure in case PPC is not defined and FIT is beng used Remy Bohmer
2009-10-29 10:53             ` Wolfgang Denk [this message]
2009-10-29 11:35               ` Remy Bohmer
2009-10-29 12:36                 ` Wolfgang Denk
2009-11-10  6:30           ` [U-Boot] [PATCH] Add error codes/handling for TFTP-server Ben Warren
2009-11-10  6:28         ` [U-Boot] [PATCH] Repair the 'netry=once' option Ben Warren
2009-11-23 22:48           ` Wolfgang Denk
2009-10-29  5:01       ` [U-Boot] [PATCH] Make the generic unaligned access code safe for unaligned access Stefan Roese
2009-10-29 11:24         ` Remy Bohmer
2009-10-29 14:30           ` Tom
2009-10-29 14:34             ` Remy Bohmer
2009-10-29 15:17               ` Tom
2009-10-29 15:34                 ` Remy Bohmer
2009-10-29 15:40                   ` Stefan Roese
2009-10-29 17:51                     ` Tom
2009-11-23 22:46       ` Wolfgang Denk
2009-11-24  4:05         ` Stefan Roese
2009-11-24 10:07           ` Remy Bohmer
2009-11-24 21:41           ` Wolfgang Denk
2009-11-23 22:44     ` [U-Boot] [PATCH] Add support for CS2 dataflash for Atmel-SPI Wolfgang Denk
2009-11-23 22:43   ` [U-Boot] [PATCH] Fix mingw tools build Wolfgang Denk
2009-11-23 22:43 ` [U-Boot] [PATCH] Building of FIT images does not work Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091029105317.DA7A419F73@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox