public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM S3C2410 add new board GEC2410
Date: Thu, 29 Oct 2009 18:58:19 -0500	[thread overview]
Message-ID: <20091029235819.GB28985@loki.buserror.net> (raw)
In-Reply-To: <1256821560-2848-1-git-send-email-zetalabs@gmail.com>

On Thu, Oct 29, 2009 at 09:05:59PM +0800, Hui.Tang wrote:
> +# PAD_TO used to generate a 4kByte binary needed for the combined image
> +# -> PAD_TO = TEXT_BASE + 4096
> +PAD_TO	:= $(shell expr $$[$(TEXT_BASE) + 4096])

Wasn't there a thread about this construct causing problems in certain
environments?  It looks like a bashism, and a deprecated (according to the
man page) and redundant (you're already using expr) one at that.

Does $(shell expr $(TEXT_BASE) + 4096) work?

-Scott

  reply	other threads:[~2009-10-29 23:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-29 13:05 [U-Boot] [PATCH] ARM S3C2410 add new board GEC2410 Hui.Tang
2009-10-29 23:58 ` Scott Wood [this message]
2009-10-30  1:44 ` Minkyu Kang
2009-10-30  3:18   ` Peter Tyser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091029235819.GB28985@loki.buserror.net \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox