From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mike Frysinger <vapier@gentoo.org>
Date: Sat, 31 Oct 2009 17:40:58 -0400
Subject: [U-Boot] [PATCH] mkconfig: deny messed up ARCH definition
In-Reply-To: <1256998321-17270-1-git-send-email-nm@ti.com>
References: <1256998321-17270-1-git-send-email-nm@ti.com>
Message-ID: <200910311740.59507.vapier@gentoo.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Saturday 31 October 2009 10:12:01 Nishanth Menon wrote:
> Refuse to setup a platform if the command
> line ARCH= is not the same as the one
> required for the board. This prevents
> any user with prehistoric aliases from
> messing up thier builds

seems like excessive line wrapping

> +if [ ! -z "$ARCH" -a "$ARCH" != "$2" ]; then

is the !-z really needed ?

> +	echo "ARCH=$ARCH while ${BOARD_NAME} arch=$2: fail"

should be sent to stderr: 1>&2
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091031/aca0c43e/attachment.pgp