From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Sat, 31 Oct 2009 17:46:43 -0400 Subject: [U-Boot] [PATCH 02/10] USB add macros for debugging usb device setup. In-Reply-To: <1257010667-10834-3-git-send-email-Tom.Rix@windriver.com> References: <1257010667-10834-1-git-send-email-Tom.Rix@windriver.com> <1257010667-10834-2-git-send-email-Tom.Rix@windriver.com> <1257010667-10834-3-git-send-email-Tom.Rix@windriver.com> Message-ID: <200910311746.44937.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Saturday 31 October 2009 13:37:39 Tom Rix wrote: > +#ifdef DEBUG > +static inline void print_device_descriptor(struct usb_device_descriptor > *d) +{ > + serial_printf("usb device descriptor \n"); do you really need serial_printf() ? what's wrong with debug() ? then you dont even really need "#ifdef DEBUG" around all the functions ... -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20091031/c16c6cfc/attachment.pgp