From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 09/10] OMAP3 USB Initialize twl4030 only if required
Date: Sat, 31 Oct 2009 17:49:11 -0400 [thread overview]
Message-ID: <200910311749.12796.vapier@gentoo.org> (raw)
In-Reply-To: <1257010667-10834-10-git-send-email-Tom.Rix@windriver.com>
On Saturday 31 October 2009 13:37:46 Tom Rix wrote:
> OMAP3EVM uses ISP1504 phy and so twl4030 related init is not required.
>
> --- a/drivers/usb/musb/omap3.c
> +++ b/drivers/usb/musb/omap3.c
> @@ -94,12 +94,17 @@ int musb_platform_init(void)
> if (platform_needs_initialization) {
> u32 stdby;
>
> + /*
> + * OMAP3EVM uses ISP1504 phy and so
> + * twl4030 related init is not required.
> + */
> +#ifdef CONFIG_TWL4030_USB
> if (twl4030_usb_ulpi_init()) {
> serial_printf("ERROR: %s Could not initialize PHY\n",
> __PRETTY_FUNCTION__);
> goto end;
> }
> -
> +#endif
shouldnt this be abstracted away (weaks/phy-common name/etc...) instead of
sprinkling ifdef's everywhere ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091031/11d4eb60/attachment.pgp
next prev parent reply other threads:[~2009-10-31 21:49 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-31 17:37 [U-Boot] v3 OMAP USB Tom Rix
2009-10-31 17:37 ` [U-Boot] [PATCH 01/10] USB Consolidate descriptor definitions Tom Rix
2009-10-31 17:37 ` [U-Boot] [PATCH 02/10] USB add macros for debugging usb device setup Tom Rix
2009-10-31 17:37 ` [U-Boot] [PATCH 03/10] TWL4030 Add usb PHY support Tom Rix
2009-10-31 17:37 ` [U-Boot] [PATCH 04/10] OMAP3 Add usb device support Tom Rix
2009-10-31 17:37 ` [U-Boot] [PATCH 05/10] OMAP3 zoom1 Add usbtty configuration Tom Rix
2009-10-31 17:37 ` [U-Boot] [PATCH 06/10] OMAP3 beagle " Tom Rix
2009-10-31 17:37 ` [U-Boot] [PATCH 07/10] USBTTY make some function declarations easier to use Tom Rix
2009-10-31 17:37 ` [U-Boot] [PATCH 08/10] OMAP3 zoom2 Use usbtty if the debug board is not connected Tom Rix
2009-10-31 17:37 ` [U-Boot] [PATCH 09/10] OMAP3 USB Initialize twl4030 only if required Tom Rix
2009-10-31 17:37 ` [U-Boot] [PATCH 10/10] omap3evm: musb: add USB config Tom Rix
2009-10-31 21:49 ` Mike Frysinger [this message]
2009-11-01 2:09 ` [U-Boot] [PATCH 09/10] OMAP3 USB Initialize twl4030 only if required Tom
2009-11-01 13:35 ` Mike Frysinger
2009-10-31 21:47 ` [U-Boot] [PATCH 08/10] OMAP3 zoom2 Use usbtty if the debug board is not connected Mike Frysinger
2009-11-01 2:03 ` Tom
2009-11-01 13:33 ` Mike Frysinger
2009-11-01 14:14 ` Tom
2009-11-01 14:55 ` Mike Frysinger
2009-10-31 21:46 ` [U-Boot] [PATCH 02/10] USB add macros for debugging usb device setup Mike Frysinger
2009-11-01 2:00 ` Tom
2009-11-01 13:32 ` Mike Frysinger
2009-11-01 14:02 ` Tom
2009-11-01 14:09 ` Mike Frysinger
2009-11-01 14:29 ` Tom
2009-11-04 15:06 ` [U-Boot] v3 OMAP USB Tom
2009-11-04 15:28 ` Mike Frysinger
2009-11-04 20:21 ` Remy Bohmer
2009-11-05 3:38 ` Gupta, Ajay Kumar
2009-11-05 9:42 ` Remy Bohmer
2009-11-05 13:44 ` Tom
2009-11-05 15:42 ` Remy Bohmer
2009-11-06 18:01 ` [U-Boot] AT91 runnable out of RAM ? Tom Rix
2009-11-07 7:50 ` Remy Bohmer
2009-11-07 12:13 ` Tom Rix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910311749.12796.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox