[U-Boot] [PATCH 05/10] ARM Add New Board GEC2410

[Wolfgang Denk <wd@denx.de>]

Dear "Hui.Tang",

In message <b9e3f7a01cba3bcd76dc29d8bad2369dc8ac0349.1256898456.git.zetalabs@gmail.com> you wrote:
> Add GEC2410 Clock Setting.
> 
> Signed-off-by: Hui.Tang <zetalabs@gmail.com>
> ---
>  cpu/arm920t/s3c24x0/timer.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/cpu/arm920t/s3c24x0/timer.c b/cpu/arm920t/s3c24x0/timer.c
> index 20cedd4..d4787b9 100644
> --- a/cpu/arm920t/s3c24x0/timer.c
> +++ b/cpu/arm920t/s3c24x0/timer.c
> @@ -188,6 +188,7 @@ ulong get_tbclk(void)
>  	tbclk = timer_load_val * 100;
>  #elif defined(CONFIG_SBC2410X) || \
>        defined(CONFIG_SMDK2410) || \
> +      defined(CONFIG_GEC2410) || \
>        defined(CONFIG_VCMA9)
>  	tbclk = CONFIG_SYS_HZ;

Instead of adding more and more board names here, we should define a
feature dependency instead - I understand this is s3c2400 versus
x3c2410 code, right? So why don't we use this instead? In any case,
such lists should always be kept sorted.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The biggest difference between time and space is that you can't reuse
time.                                                 - Merrick Furst