From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Sun, 1 Nov 2009 09:38:08 -0400 Subject: [U-Boot] [PATCH] mkconfig: deny messed up ARCH definition In-Reply-To: <7A436F7769CA33409C6B44B358BFFF0C012AE7CAE2@dlee02.ent.ti.com> References: <1256998321-17270-1-git-send-email-nm@ti.com> <200910311740.59507.vapier@gentoo.org> <7A436F7769CA33409C6B44B358BFFF0C012AE7CAE2@dlee02.ent.ti.com> Message-ID: <200911010838.08938.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Saturday 31 October 2009 18:20:06 Menon, Nishanth wrote: > From: Mike Frysinger > > On Saturday 31 October 2009 10:12:01 Nishanth Menon wrote: > > > +if [ ! -z "$ARCH" -a "$ARCH" != "$2" ]; then > > > > is the !-z really needed ? > > We don't want the check to trigger if ARCH is not defined. > [ "$ARCH" != "$2" ] will trigger as "" != "arm" the implied question is whether this is a valid state. i know you dont want that kind of comparison, but i thought the Makefile would have set it up for you by default. now that i think about it a bit more, that isnt what happens at all. so only thing to change here is to use -n and not !-z -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20091101/e64b37c3/attachment.pgp