From: Wolfgang Wegner <wolfgang@leila.ping.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH] Implementation of non-blocking flash write/erase/status check functions.
Date: Mon, 2 Nov 2009 17:33:53 +0100 [thread overview]
Message-ID: <20091102163353.GV3216@leila.ping.de> (raw)
In-Reply-To: <20091030182217.7C86419F38@gemini.denx.de>
Dear Wolfgang Denk,
On Fri, Oct 30, 2009 at 07:22:17PM +0100, Wolfgang Denk wrote:
[...]
> > 2 files changed, 365 insertions(+), 78 deletions(-)
>
> This summary alone is a pretty clear message to me. This is indeed a
> lot of added, and even worse, duplicated code.
I tried to address this by re-working the code to completely avoid
duplicate code. This leads to a much tighter integration, I do not
know if this is wanted by the CFI/flash maintainers.
The patch is on its way - comments are highly welcome, as I do not
see a real conflict of the underlying idea to the U-Boot design
principles, I am definitely willing to address all implementation/
coding style issues in case this helps to change your mind. :-)
Best regards,
Wolfgang Wegner
next prev parent reply other threads:[~2009-11-02 16:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-27 12:51 [U-Boot] non-blocking flash functions - is this possible/acceptable? Wolfgang Wegner
2009-10-27 13:21 ` Jerry Van Baren
2009-10-27 14:03 ` Jerry Van Baren
2009-10-27 15:22 ` Wolfgang Wegner
2009-10-27 15:57 ` Jerry Van Baren
2009-10-27 15:24 ` Wolfgang Wegner
2009-10-27 18:58 ` Wolfgang Denk
2009-10-30 14:48 ` [U-Boot] [RFC PATCH] Implementation of non-blocking flash write/erase/status check functions Wolfgang Wegner
2009-10-30 15:02 ` Wolfgang Wegner
2009-10-30 18:22 ` Wolfgang Denk
2009-11-02 16:26 ` [U-Boot] [PATCH] " Wolfgang Wegner
2009-11-02 16:33 ` Wolfgang Wegner [this message]
2009-12-09 16:00 ` [U-Boot] [PATCH RFC v2] " Wolfgang Wegner
2010-01-22 10:03 ` Wolfgang Wegner
2010-01-22 12:03 ` Wolfgang Denk
2010-01-25 8:35 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091102163353.GV3216@leila.ping.de \
--to=wolfgang@leila.ping.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox