From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Wegner Date: Mon, 2 Nov 2009 17:33:53 +0100 Subject: [U-Boot] [RFC PATCH] Implementation of non-blocking flash write/erase/status check functions. In-Reply-To: <20091030182217.7C86419F38@gemini.denx.de> References: <20091027185822.8E7BEE916D5@gemini.denx.de> <1256914121-26044-1-git-send-email-w.wegner@astro-kom.de> <20091030182217.7C86419F38@gemini.denx.de> Message-ID: <20091102163353.GV3216@leila.ping.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Wolfgang Denk, On Fri, Oct 30, 2009 at 07:22:17PM +0100, Wolfgang Denk wrote: [...] > > 2 files changed, 365 insertions(+), 78 deletions(-) > > This summary alone is a pretty clear message to me. This is indeed a > lot of added, and even worse, duplicated code. I tried to address this by re-working the code to completely avoid duplicate code. This leads to a much tighter integration, I do not know if this is wanted by the CFI/flash maintainers. The patch is on its way - comments are highly welcome, as I do not see a real conflict of the underlying idea to the U-Boot design principles, I am definitely willing to address all implementation/ coding style issues in case this helps to change your mind. :-) Best regards, Wolfgang Wegner