public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH (repost)] Nomadik: fix reset_timer()
Date: Tue, 03 Nov 2009 14:27:12 +0100	[thread overview]
Message-ID: <20091103132712.950203F6EC@gemini.denx.de> (raw)
In-Reply-To: <20091103121250.GA8577@mail.gnudd.com>

Dear Alessandro Rubini,

In message <20091103121250.GA8577@mail.gnudd.com> you wrote:
> From: Alessandro Rubini <rubini@unipv.it>
> 
> The timer decrements and READ_TIMER() negates the value read.
> Writing 0 in reset_timer() is this wrong, as a readback before 400us
> will read back 0 and will report 1780 seconds, so nand operations did
> timeout.  This patch writes ~0 in reset_timer to prevent this.
> 
> Signed-off-by: Alessandro Rubini <rubini@unipv.it>
> Acked-by: Andrea Gallo <andrea.gallo@stericsson.com>
> ---
> 
> This must be applied for nand to work. It's a simple bugfix so
> I think it got simply forgotten.

Um... why is READ_TIMER doing such a stupid thing as negating values?
This is not what it is supposed to do - as the name says, it should
_read_ the _timer_. There is no mentioning of "NEgATE" anywhere?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The majority of the stupid is  invincible  and  guaranteed  for  all
time.  The  terror  of their tyranny, however, is alleviated by their
lack of consistency."                               - Albert Einstein

  reply	other threads:[~2009-11-03 13:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-03 12:12 [U-Boot] [PATCH (repost)] Nomadik: fix reset_timer() Alessandro Rubini
2009-11-03 13:27 ` Wolfgang Denk [this message]
2009-11-03 15:23   ` Alessandro Rubini
2009-11-03 15:59     ` Wolfgang Denk
2009-11-03 16:03       ` Alessandro Rubini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091103132712.950203F6EC@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox