[U-Boot] [PATCH] Adding support for Linuxstamp II 9260

Wolfgang Denk
2009-11-03T21:33:56Z

Dear Paul Thomas,

please check/fix your mail addresses.

In message <1257282760-18005-1-git-send-email-pthomas8589@gmail.com> you wrote:
> From: Paul Thomas <pthomas@black.(none)>

Signed-off-by: line is missing.

> ---
> Makefile | 3 +
> board/linuxstamp/at91sam9260ls/Makefile | 56 ++++++
> board/linuxstamp/at91sam9260ls/at91sam9260ls.c | 203 +++++++++++++++++++++
> board/linuxstamp/at91sam9260ls/config.mk | 1 +
> board/linuxstamp/at91sam9260ls/led.c | 41 +++++
> board/linuxstamp/at91sam9260ls/partition.c | 40 +++++
> include/configs/at91sam9260ls.h | 223 ++++++++++++++++++++++++
> 7 files changed, 567 insertions(+), 0 deletions(-)
> create mode 100644 board/linuxstamp/at91sam9260ls/Makefile
> create mode 100644 board/linuxstamp/at91sam9260ls/at91sam9260ls.c
> create mode 100644 board/linuxstamp/at91sam9260ls/config.mk
> create mode 100644 board/linuxstamp/at91sam9260ls/led.c
> create mode 100644 board/linuxstamp/at91sam9260ls/partition.c
> create mode 100644 include/configs/at91sam9260ls.h

Entries to MAKEALL an MAINTAINERS are missing.

> diff --git a/Makefile b/Makefile
> index bcb3fe9..d8efa66 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2761,6 +2761,9 @@ at91sam9g20ek_config : unconfig
> fi;
> @$(MKCONFIG) -a at91sam9260ek arm arm926ejs at91sam9260ek atmel at91
>
> +at91sam9260ls_config : unconfig
> + @$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9260ls linuxstamp at91

When the board name is Linuxstamp, and the board directory name is
linuxstamp, then the board config file name and make target name
should be linuxstamp, too.

> at91sam9xeek_nandflash_config \
> at91sam9xeek_dataflash_cs0_config \
> at91sam9xeek_dataflash_cs1_config \
> diff --git a/board/linuxstamp/at91sam9260ls/Makefile b/board/linuxstamp/at91sam9260ls/Makefile
> new file mode 100644
> index 0000000..2a0ef78
> --- /dev/null
> +++ b/board/linuxstamp/at91sam9260ls/Makefile
> @@ -0,0 +1,56 @@
> +#
> +# (C) Copyright 2003-2008
> +# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
> +#
> +# (C) Copyright 2008
> +# Stelian Pop <stelian.pop@leadtechdesign.com>
> +# Lead Tech Design <www.leadtechdesign.com>
> +#
> +# See file CREDITS for list of people who contributed to this
> +# project.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation; either version 2 of
> +# the License, or (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write to the Free Software
> +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> +# MA 02111-1307 USA
> +#
> +
> +include $(TOPDIR)/config.mk
> +
> +LIB = $(obj)lib$(BOARD).a
> +
> +COBJS-y += at91sam9260ls.o
> +COBJS-y += led.o
> +COBJS-$(CONFIG_HAS_DATAFLASH) += partition.o
> +
> +SRCS := $(SOBJS:.o=.S) $(COBJS-y:.o=.c)
> +OBJS := $(addprefix $(obj),$(COBJS-y))
> +SOBJS := $(addprefix $(obj),$(SOBJS))
> +
> +$(LIB): $(obj).depend $(OBJS) $(SOBJS)
> + $(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS)
> +
> +clean:
> + rm -f $(SOBJS) $(OBJS)
> +
> +distclean: clean
> + rm -f $(LIB) core *.bak $(obj).depend
> +
> +#########################################################################
> +
> +# defines $(obj).depend target
> +include $(SRCTREE)/rules.mk
> +
> +sinclude $(obj).depend
> +
> +#########################################################################
> diff --git a/board/linuxstamp/at91sam9260ls/at91sam9260ls.c b/board/linuxstamp/at91sam9260ls/at91sam9260ls.c
> new file mode 100644
> index 0000000..a1c4466
> --- /dev/null
> +++ b/board/linuxstamp/at91sam9260ls/at91sam9260ls.c
> @@ -0,0 +1,203 @@
> +/*
> + * (C) Copyright 2007-2008
> + * Stelian Pop <stelian.pop@leadtechdesign.com>
> + * Lead Tech Design <www.leadtechdesign.com>
> + *
> + * (C) Copyright 2009
> + * Paul Thomas <pthomas8589@gmail.com>
> + * http://opencircuits.com/Linuxstamp_II_9260
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#include <common.h>
> +#include <asm/arch/at91sam9260.h>
> +#include <asm/arch/at91sam9260_matrix.h>
> +#include <asm/arch/at91sam9_smc.h>
> +#include <asm/arch/at91_common.h>
> +#include <asm/arch/at91_pmc.h>
> +#include <asm/arch/at91_rstc.h>
> +#include <asm/arch/gpio.h>
> +#include <asm/arch/io.h>
> +#include <asm/arch/hardware.h>
> +#if defined(CONFIG_RESET_PHY_R) && defined(CONFIG_MACB)
> +#include <net.h>
> +#endif
> +#include <netdev.h>
> +
> +DECLARE_GLOBAL_DATA_PTR;
> +
> +/* ------------------------------------------------------------------------- */
> +/*
> + * Miscelaneous platform dependent initialisations
> + */
> +
> +#ifdef CONFIG_CMD_NAND
> +static void at91sam9260ls_nand_hw_init(void)
> +{
> + unsigned long csa;
> +
> + /* Enable CS3 */
> + csa = at91_sys_read(AT91_MATRIX_EBICSA);
> + at91_sys_write(AT91_MATRIX_EBICSA,
> + csa | AT91_MATRIX_CS3A_SMC_SMARTMEDIA);
> +
> + /* Configure SMC CS3 for NAND/SmartMedia */
> + at91_sys_write(AT91_SMC_SETUP(3),
> + AT91_SMC_NWESETUP_(1) | AT91_SMC_NCS_WRSETUP_(0) |
> + AT91_SMC_NRDSETUP_(1) | AT91_SMC_NCS_RDSETUP_(0));
> + at91_sys_write(AT91_SMC_PULSE(3),
> + AT91_SMC_NWEPULSE_(3) | AT91_SMC_NCS_WRPULSE_(3) |
> + AT91_SMC_NRDPULSE_(3) | AT91_SMC_NCS_RDPULSE_(3));
> + at91_sys_write(AT91_SMC_CYCLE(3),
> + AT91_SMC_NWECYCLE_(5) | AT91_SMC_NRDCYCLE_(5));
> + at91_sys_write(AT91_SMC_MODE(3),
> + AT91_SMC_READMODE | AT91_SMC_WRITEMODE |
> + AT91_SMC_EXNWMODE_DISABLE |
> +#ifdef CONFIG_SYS_NAND_DBW_16
> + AT91_SMC_DBW_16 |
> +#else /* CONFIG_SYS_NAND_DBW_8 */
> + AT91_SMC_DBW_8 |
> +#endif
> + AT91_SMC_TDF_(2));

Argh... AT91 "style" again. we should really clean up all this mess
one day...

...
> +#ifdef CONFIG_AT91SAM9G20EK
> + /* arch number of AT91SAM9260EK-Board */
> + gd->bd->bi_arch_number = MACH_TYPE_AT91SAM9G20EK;
> +#else
> + /* arch number of AT91SAM9260EK-Board */
> + gd->bd->bi_arch_number = MACH_TYPE_AT91SAM9260EK;
> +#endif

This seems to be wrong. Should this not be something like
MACH_TYPE_STAMP9G20 instead?

> +#ifdef CONFIG_RESET_PHY_R
> +void reset_phy(void)
> +{
> +#ifdef CONFIG_MACB
> + /*
> + * Initialize ethernet HW addr prior to starting Linux,
> + * needed for nfsroot
> + */
> + eth_init(gd->bd);
> +#endif
> +}

NAK. Please fix your Linux drivers instead. See
http://www.denx.de/wiki/view/DULG/EthernetDoesNotWorkInLinux

> diff --git a/include/configs/at91sam9260ls.h b/include/configs/at91sam9260ls.h
> new file mode 100644
> index 0000000..ba823ea
> --- /dev/null
> +++ b/include/configs/at91sam9260ls.h

see above for choice of file name.

> +#define CONFIG_AT91SAM9260 1 /* It's an Atmel AT91SAM9260 SoC*/
> +#define CONFIG_AT91SAM9260EK 1 /* This in needed in places like the macb setup in at91sam9260_devices*/

This is most certainly NOT a AT91SAM9260EK board, right?

> +#define CONFIG_ARCH_CPU_INIT
> +#undef CONFIG_USE_IRQ /* we don't need IRQ/FIQ stuff */

Don't undef what is not defined anyway.

> +#define CONFIG_CMDLINE_TAG 1 /* enable passing of ATAGs */
> +#define CONFIG_SETUP_MEMORY_TAGS 1
> +#define CONFIG_INITRD_TAG 1
> +
> +#define CONFIG_SKIP_LOWLEVEL_INIT
> +#define CONFIG_SKIP_RELOCATE_UBOOT
> +
> +/*
> + * Hardware drivers
> + */
> +#define CONFIG_ATMEL_USART 1
> +#undef CONFIG_USART0
> +#undef CONFIG_USART1
> +#undef CONFIG_USART2

Ditto.

> +#include <config_cmd_default.h>
> +#undef CONFIG_CMD_BDI
> +#undef CONFIG_CMD_FPGA
> +#undef CONFIG_CMD_IMI
> +#undef CONFIG_CMD_IMLS
> +#undef CONFIG_CMD_LOADS
> +#undef CONFIG_CMD_SOURCE

Is there any specific reason for disabling lots of pretty useful
commands? Are you so tight on flash memory or RAM?

> +#ifdef CONFIG_AT91SAM9G20EK

AT91SAM9G20EK ?

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A Puritan is someone who is deathly afraid that someone, somewhere,
is having fun.