public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Save environment data to mmc.
Date: Thu, 5 Nov 2009 08:09:42 -0400	[thread overview]
Message-ID: <200911050709.43285.vapier@gentoo.org> (raw)
In-Reply-To: <12574070132761-git-send-email-r65388@freescale.com>

On Thursday 05 November 2009 02:43:33 Terry Lv wrote:
> --- a/common/Makefile
> +++ b/common/Makefile
> @@ -58,6 +58,7 @@ COBJS-$(CONFIG_ENV_IS_IN_NAND) += env_nand.o
>  COBJS-$(CONFIG_ENV_IS_IN_NVRAM) += env_nvram.o
>  COBJS-$(CONFIG_ENV_IS_IN_ONENAND) += env_onenand.o
>  COBJS-$(CONFIG_ENV_IS_IN_SPI_FLASH) += env_sf.o
> +COBJS-$(CONFIG_ENV_IS_IN_MMC) += env_mmc.o

this list is attempting to stay in order according to the CONFIG name, so you 
should add this above the NAND ENV entry

> --- /dev/null
> +++ b/common/env_mmc.c
> @@ -0,0 +1,359 @@
> +#if defined(CONFIG_ENV_IS_IN_MMC) /* Environment is in MMC Flash */

you dont need this line anymore as it's in the Makefile

> +#ifdef CONFIG_INFERNO
> +#error CONFIG_INFERNO not supported yet
> +#endif

is this really needed ?

> +extern int default_environment_size;

this looks like another useless line copy & pasted from whatever file you 
based this on
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091105/7cd8ba61/attachment.pgp 

  reply	other threads:[~2009-11-05 12:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-05  7:43 [U-Boot] [PATCH] Save environment data to mmc Terry Lv
2009-11-05 12:09 ` Mike Frysinger [this message]
2009-11-06  1:54   ` Lv Terry-R65388
2009-11-05 18:52 ` Wolfgang Denk
  -- strict thread matches above, loose matches on Subject: below --
2010-04-29  7:40 Terry Lv
2010-04-29 14:33 ` Stefano Babic
2010-04-30  3:47   ` Lv Terry-R65388
2010-04-30 13:14     ` Stefano Babic
2010-04-28  7:52 Terry Lv
2010-04-28 13:30 ` Andy Fleming
2009-11-19  6:58 Terry Lv
2010-03-02 17:03 ` Stefano Babic
2010-03-04  3:01   ` Lv Terry-R65388
2010-03-04  3:07     ` Liu Hui-R64343
2009-11-04 10:02 Terry Lv
2009-11-04 11:01 ` Mike Frysinger
2009-11-05  7:45   ` Lv Terry-R65388
2009-11-04  9:51 Terry Lv
2009-11-04  9:55 ` Lv Terry-R65388

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200911050709.43285.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox