public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/2]: common: Add a watchdog CLI command
Date: Fri, 6 Nov 2009 07:18:27 -0400	[thread overview]
Message-ID: <200911060618.28725.vapier@gentoo.org> (raw)
In-Reply-To: <20091106102823.2e259845@marrow.netinsight.se>

On Friday 06 November 2009 04:28:23 Simon Kagstrom wrote:
> (Ping!)
> 
> On Thu, 29 Oct 2009 09:09:23 +0100
> 
> Simon Kagstrom <simon.kagstrom@netinsight.net> wrote:
> > A watchdog command to enable the watchdog with a timeout from the CLI
> > can sometimes be useful. Add that. This also adds a common API for
> > enabling watchdogs. The API is simple:
> >
> >         int watchdog_enable(unsigned int timeout);
> >
> > the timeout range vary depending on hardware, and the driver should
> > return a negative value if the call failed.
> 
> Wolfgang: Do you have any additional comments on this patch?

here's one: dont quote the entire e-mail when you dont need to.  you force 
people to scan the entire thing looking for possible inline comments.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091106/85b90f82/attachment.pgp 

  parent reply	other threads:[~2009-11-06 11:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-28 14:11 [U-Boot] [PATCH 0/2]: Watchdog support from the command line Simon Kagstrom
2009-10-28 14:14 ` [U-Boot] [PATCH 1/2]: common: Add a watchdog CLI command Simon Kagstrom
2009-10-28 14:29   ` Prafulla Wadaskar
2009-10-28 14:49     ` Simon Kagstrom
2009-10-28 15:56       ` Wolfgang Denk
2009-10-28 14:15 ` [U-Boot] [PATCH 2/2]: arm:kirkwood: Add hardware watchdog support for Marvell Kirkwood boards Simon Kagstrom
2009-10-28 15:41   ` Prafulla Wadaskar
2009-10-29  8:07 ` [U-Boot] [PATCH v2 0/2]: Watchdog support from the command line Simon Kagstrom
2009-10-29  8:09   ` [U-Boot] [PATCH v2 1/2]: common: Add a watchdog CLI command Simon Kagstrom
2009-10-29  8:29     ` Prafulla Wadaskar
2009-11-06  9:28     ` Simon Kagstrom
2009-11-06  9:34       ` Prafulla Wadaskar
2009-11-06 11:18       ` Mike Frysinger [this message]
2009-10-29  8:11   ` [U-Boot] [PATCH v2 2/2]: arm:kirkwood: Add hardware watchdog support for Marvell Kirkwood boards Simon Kagstrom
2009-10-29  8:32     ` Prafulla Wadaskar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200911060618.28725.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox