From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] smc91111_eeprom: fix compile warning
Date: Mon, 9 Nov 2009 16:36:54 -0500 [thread overview]
Message-ID: <200911091636.54896.vapier@gentoo.org> (raw)
In-Reply-To: <1257801598-30823-1-git-send-email-biggerbadderben@gmail.com>
On Monday 09 November 2009 16:19:58 Ben Warren wrote:
> smc91111_eeprom.c:278: warning: suggest parentheses around + or - in
> operand
> smc91111_eeprom.c:281: warning: suggest parentheses around + or -
> in operand
>
> for (i = 0; i < 5; i++) {
> - printf ("%02x:", SMC_inb (dev, ADDR0_REG + i));
> + printf ("%02x:", SMC_inb (dev, (ADDR0_REG + i)));
> }
erm, this says to me that the SMC inb macro is broken. it should be using
paren when expanding the second argument. so lets fix that instead.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091109/e62a8ad3/attachment.pgp
next prev parent reply other threads:[~2009-11-09 21:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 21:19 [U-Boot] [PATCH] smc91111_eeprom: fix compile warning Ben Warren
2009-11-09 21:36 ` Mike Frysinger [this message]
2009-11-09 21:41 ` Ben Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911091636.54896.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox