From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Mon, 9 Nov 2009 16:36:54 -0500 Subject: [U-Boot] [PATCH] smc91111_eeprom: fix compile warning In-Reply-To: <1257801598-30823-1-git-send-email-biggerbadderben@gmail.com> References: <1257801598-30823-1-git-send-email-biggerbadderben@gmail.com> Message-ID: <200911091636.54896.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday 09 November 2009 16:19:58 Ben Warren wrote: > smc91111_eeprom.c:278: warning: suggest parentheses around + or - in > operand > smc91111_eeprom.c:281: warning: suggest parentheses around + or - > in operand > > for (i = 0; i < 5; i++) { > - printf ("%02x:", SMC_inb (dev, ADDR0_REG + i)); > + printf ("%02x:", SMC_inb (dev, (ADDR0_REG + i))); > } erm, this says to me that the SMC inb macro is broken. it should be using paren when expanding the second argument. so lets fix that instead. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20091109/e62a8ad3/attachment.pgp