From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Date: Mon, 9 Nov 2009 14:02:22 -0600
Subject: [U-Boot] [PATCH 3/3] [OneNAND] Flex-OneNAND boundary settings
In-Reply-To: <DB01E78930CF4B429517162B35FE1322@sisodomain.com>
References: <C777524EC3ED42A397A07356115F4B81@sisodomain.com>
	<C8B0D89A196544F388B778388D549E61@sisodomain.com>
	<20091105230827.GB13402@loki.buserror.net>
	<2E6062627A7F4DAA947D483FEB217B94@sisodomain.com>
	<DB01E78930CF4B429517162B35FE1322@sisodomain.com>
Message-ID: <20091109200222.GA11164@loki.buserror.net>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Fri, Nov 06, 2009 at 05:17:44PM +0530, Amul Kumar Saha wrote:
> -			printk("Bad blocks %d at 0x%x\n",
> -			       (u32)(ofs >> this->erase_shift), (u32)ofs);
> +			printk("Bad blocks %lu at 0x%x\n",
> +			       (u32)onenand_block(this, ofs), (u32)ofs);

cmd_onenand.c: In function ?onenand_block_read?:
cmd_onenand.c:103: warning: format ?%lu? expects type ?long unsigned int?,
but argument 2 has type ?unsigned int?

If you must pass a u32 to printf, use "%u" or "%x" -- but it makes little
sense to explicitly cast from int to something that doesn't have a standard
printf format string.

How about this?

+			printk("Bad block %d at 0x%llx\n",
+			       onenand_block(this, ofs), ofs);

Likewise throughout the rest of the file.

-Scott