public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 2/3] mxc_nand: Update driver to work with	i.MX31.
Date: Wed, 11 Nov 2009 14:56:42 -0600	[thread overview]
Message-ID: <20091111205642.GA12671@loki.buserror.net> (raw)
In-Reply-To: <5e2ba58d09eb3857a20eb6c4d6761d6623aff751.1257966944.git.lilja.magnus@gmail.com>

On Wed, Nov 11, 2009 at 08:18:43PM +0100, Magnus Lilja wrote:
> +#ifdef CONFIG_MX27
> +static int is_16bit_nand(void)
> +{
> +	struct system_control_regs *sc_regs =
> +		(struct system_control_regs *)IMX_SYSTEM_CTL_BASE;
> +
> +	if (readl(&sc_regs->fmcr) & NF_16BIT_SEL)
> +		return 1;
> +	else
> +		return 0;
> +}
> +#elif defined(CONFIG_MX31)
> +static int is_16bit_nand(void)
> +{
> +	struct clock_control_regs *sc_regs =
> +		(struct clock_control_regs *)CCM_BASE;

Maybe call the clock_control regs cc_regs?

Otherwise ACK, assuming this is ARM-tree bound.

-Scott

      parent reply	other threads:[~2009-11-11 20:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-11 19:18 [U-Boot] [PATCH v1 0/3] MXC: Add NAND support for i.MX31 Magnus Lilja
2009-11-11 19:18 ` [U-Boot] [PATCH v1 1/3] MX31: Add struct definition for clock control module in i.MX31 Magnus Lilja
2009-11-11 19:18   ` [U-Boot] [PATCH v1 2/3] mxc_nand: Update driver to work with i.MX31 Magnus Lilja
2009-11-11 19:18     ` [U-Boot] [PATCH v1 3/3] MX31: Activate NAND support for i.MX31 Litekit board Magnus Lilja
2009-11-11 20:56     ` Scott Wood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091111205642.GA12671@loki.buserror.net \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox