From: Alessandro Rubini <rubini-list@gnudd.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] ARM Conditionally compile board LED functions
Date: Thu, 12 Nov 2009 16:17:29 +0100 [thread overview]
Message-ID: <20091112151729.GA22481@mail.gnudd.com> (raw)
In-Reply-To: <4AF360E7.1090906@windriver.com>
> I withdraw this patch.
> I will rethink this and come up with something better.
I agree weak is better than ifdef. But the led situation on ARM isn't
really pleasant when you look in lib_arm/board.c .
When I proposed a simplification of board.c back on Jul 22 ("[RFC]
arm/board.c: avoid ifdef using weak default functions", I noticed the
led approach and thought it would need cleanup (for example, by moving
out of board.c to led.c or something). However, the patch was
rejected by JC as he has initcalls as work in progress.
Since we still missing the initcalls (as missing JC), could that patch
be reconsidered? I can rebase if there's any interest.
/alessandro
next prev parent reply other threads:[~2009-11-12 15:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 0:00 [U-Boot] ARM LED weak symbols Tom Rix
2009-11-04 0:00 ` [U-Boot] [PATCH 1/2] ARM Conditionally compile board LED functions Tom Rix
2009-11-04 0:00 ` [U-Boot] [PATCH 2/2] ARM: fix build error with gcc-4.4.2 about inline function declared weak Tom Rix
2009-11-04 0:34 ` [U-Boot] multiple partitions in mtdparts myuboot at fastmail.fm
2009-11-04 7:14 ` Dieter Kiermaier
2009-11-04 15:35 ` myuboot at fastmail.fm
2009-11-04 15:57 ` Wolfgang Denk
2009-11-05 20:19 ` [U-Boot] [PATCH 2/2] ARM: fix build error with gcc-4.4.2 about inline function declared weak Wolfgang Denk
2009-11-05 20:39 ` Tom
2009-11-05 22:38 ` Wolfgang Denk
2009-11-10 19:34 ` Tom
2009-11-10 22:45 ` Wolfgang Denk
2009-11-12 0:43 ` [U-Boot] ARM pull request Tom
2009-11-15 21:39 ` Wolfgang Denk
2009-11-11 16:53 ` [U-Boot] [PATCH 2/2] ARM: fix build error with gcc-4.4.2 about inline function declared weak Gaye Abdoulaye Walsimou
2009-11-05 20:24 ` [U-Boot] [PATCH 1/2] ARM Conditionally compile board LED functions Wolfgang Denk
2009-11-05 20:47 ` Tom
2009-11-05 22:43 ` Wolfgang Denk
2009-11-05 23:33 ` Tom
2009-11-12 15:17 ` Alessandro Rubini [this message]
2009-11-12 15:59 ` Tom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091112151729.GA22481@mail.gnudd.com \
--to=rubini-list@gnudd.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox