public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/5] smc911x: use dev->name in printfs
Date: Thu, 12 Nov 2009 22:21:09 -0500	[thread overview]
Message-ID: <200911122221.10183.vapier@gentoo.org> (raw)
In-Reply-To: <f870da180911120113l6c196f36u178e2761aa08a2eb@mail.gmail.com>

On Thursday 12 November 2009 04:13:48 Mike Rapoport wrote:
> On Thu, Nov 12, 2009 at 12:50 AM, Mike Frysinger wrote:
> > here's my [compile] tested change as the board i have with this part isnt
> > readily accessible atm ...
> 
> I've tested your changes, MAC register dumps works Ok. I needed to
> make some changes to make it work, see the comments below.
> 
> > --- a/examples/standalone/smc911x_eeprom.c
> > +++ b/examples/standalone/smc911x_eeprom.c
> > @@ -17,8 +17,8 @@
> >  #include <common.h>
> >  #include <exports.h>
> >
> > -#ifdef CONFIG_DRIVER_SMC911X
> > -
> > +/* the smc911x.h gets base addr through eth_device' iobase */
> > +struct eth_device { const char *name; unsigned long iobase; };
> 
> Needed to add 'void *priv' needed for smc911x_detect_chip, otherwise
> it does not compile with the latest U-Boot.

i wrote it against last release which didnt need this.  looking at smc911x.h, 
obviously priv is needed now and shouldnt be a problem adding it.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091112/7bc039a5/attachment.pgp 

  reply	other threads:[~2009-11-13  3:21 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-11  8:02 [U-Boot] [PATCH 0/5] smc911x driver fixes and additions Mike Rapoport
2009-11-11  8:03 ` [U-Boot] [PATCH 1/5] smc911x: return -1 when initialization fails Mike Rapoport
2009-11-11 15:16   ` Mike Frysinger
2009-11-12 13:35     ` [U-Boot] [PATCH] smc911x: make smc911x_initialize return correct value (Was: Re: [PATCH 1/5] smc911x: return -1 when initialization fails) Mike Rapoport
2009-11-13  3:44       ` Mike Frysinger
2009-11-11  8:03 ` [U-Boot] [PATCH 2/5] smc911x: use dev->name in printfs Mike Rapoport
2009-11-11 15:18   ` Mike Frysinger
2009-11-11 21:56     ` Mike Rapoport
2009-11-11 22:11       ` Mike Frysinger
2009-11-11 22:24         ` Mike Rapoport
2009-11-11 22:36           ` Mike Frysinger
2009-11-11 22:45             ` Ben Warren
2009-11-11 22:50               ` Mike Frysinger
2009-11-12  1:58                 ` Ben Warren
2009-11-13  3:23                   ` [U-Boot] [PATCH] smc911x_eeprom: fix building after smc911x overhaul Mike Frysinger
2009-11-13  3:26                     ` [U-Boot] [PATCH v2] " Mike Frysinger
2009-11-12  9:13                 ` [U-Boot] [PATCH 2/5] smc911x: use dev->name in printfs Mike Rapoport
2009-11-13  3:21                   ` Mike Frysinger [this message]
2009-11-11  8:03 ` [U-Boot] [PATCH 3/5] smc911x: silence MAC mismatch warning Mike Rapoport
2009-11-11 15:22   ` Mike Frysinger
2009-11-11 16:07     ` Mike Rapoport
2009-11-11  8:03 ` [U-Boot] [PATCH 4/5] smc911x: update SMC911X related configuration description Mike Rapoport
2009-12-07 21:06   ` Wolfgang Denk
2009-12-07 21:10     ` Ben Warren
2009-11-11  8:03 ` [U-Boot] [PATCH 5/5] smc911x: allow mac address to be kept after smc911x_halt Mike Rapoport
2009-11-11 15:23   ` Mike Frysinger
2009-11-11 16:05     ` Mike Rapoport
2009-11-11 16:32       ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200911122221.10183.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox