public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] flash.h: pull in common.h for types
Date: Mon, 16 Nov 2009 17:03:32 -0500	[thread overview]
Message-ID: <200911161703.46965.vapier@gentoo.org> (raw)
In-Reply-To: <20091116213127.14F5E3F6C2@gemini.denx.de>

On Monday 16 November 2009 16:31:27 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> > ---
> >  include/flash.h |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/flash.h b/include/flash.h
> > index c5e7bf4..886d8ef 100644
> > --- a/include/flash.h
> > +++ b/include/flash.h
> > @@ -25,6 +25,9 @@
> >  #define _FLASH_H_
> >
> >  #ifndef CONFIG_SYS_NO_FLASH
> > +
> > +#include <common.h>
> > +
> 
> Why would that be needed? Which problem are you trying to solve?

like the subject very briefly says, 'for types'.  if your source code includes 
flash.h before anything else, it'll fail to compile as flash.h uses types not 
declared implicitly by the compiler.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091116/d6081938/attachment.pgp 

  reply	other threads:[~2009-11-16 22:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-16 19:58 [U-Boot] [PATCH] flash.h: pull in common.h for types Mike Frysinger
2009-11-16 21:31 ` Wolfgang Denk
2009-11-16 22:03   ` Mike Frysinger [this message]
2009-11-17 21:00     ` Wolfgang Denk
2009-11-17 21:10       ` Scott Wood
2009-11-17 21:56         ` Wolfgang Denk
2009-11-18  0:01           ` Scott Wood
2009-11-18  0:18           ` Mike Frysinger
2009-11-18  1:34             ` J. William Campbell
2009-11-18 22:28             ` Wolfgang Denk
2009-11-18 23:43               ` Mike Frysinger
2010-01-18  1:52 ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200911161703.46965.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox