From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Wed, 18 Nov 2009 11:49:52 -0600 Subject: [U-Boot] [PATCH V5 1/4] add TI DA8xx support: DA8xx includes In-Reply-To: <20091117230946.F0FEEF51B07@gemini.denx.de> References: <4AF9823C.8090803@gefanuc.com> <20091117230946.F0FEEF51B07@gemini.denx.de> Message-ID: <20091118174951.GA15341@loki.buserror.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Nov 18, 2009 at 12:09:46AM +0100, Wolfgang Denk wrote: > In message <4AF9823C.8090803@gefanuc.com> you wrote: > > Provides initial support for TI OMAP-L1x/DA8xx SoC devices. > > See http://www.ti.com > > > > The DA8xx devices are similar to DaVinci devices but have a differing > > memory map and updated peripheral versions. > > > > Signed-off-by: Nick Thompson > > Signed-off-by: Sekhar Nori > ... > > +enum davinci_lpsc_ids { > > + DAVINCI_LPSC_TPCC = 0, > > + DAVINCI_LPSC_TPTC0, > > + DAVINCI_LPSC_TPTC1, > > + DAVINCI_LPSC_AEMIF, > > + DAVINCI_LPSC_SPI0, > > + DAVINCI_LPSC_MMC_SD, [snip] > > + DAVINCI_LPSC_eQEP, > > + DAVINCI_LPSC_SCR_P0, > > + DAVINCI_LPSC_SCR_P1, > > + DAVINCI_LPSC_CR_P3, > > + DAVINCI_LPSC_L3_CBA_RAM > > +}; > > Variable names must be lower case. Please fix. I suspect the compiler would take issue if you tried to vary those constants... -Scott