[U-Boot] [PATCH] Repair build failure in case PPC is not defined and FIT is beng used.

Remy Bohmer
2009-10-29T11:35:50Z

Hi Wolfgang,

2009/10/29 Wolfgang Denk <wd@denx.de>:
> Dear Remy Bohmer,
>
> please pay a little more attention to the commit subjects (here:
> s/beng/being/, please); also, make sure the subject is short enough
> for a commit message title line.

OK.

>>
>> +#if defined(CONFIG_PPC)
>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? images->fit_hdr_fdt = fit_hdr;
>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? images->fit_uname_fdt = fit_uname_fdt;
>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? images->fit_noffset_fdt = fdt_noffset;
>> +#endif
>
> NAK. This code is in no way dependent on the Power architecture, so
> CONFIG_PPC is definitly the wrong thing to check for.

Well, in include/image.h, line 223 this is listed:
-------------------------------------------------------------------------------
#if defined(CONFIG_PPC)
void *fit_hdr_fdt; /* FDT blob FIT image header */
const char *fit_uname_fdt; /* FDT blob subimage node unit name */
int fit_noffset_fdt;/* FDT blob subimage node offset */
#endif
-------------------------------------------------------------------------------

So, you are saying the bug is in the header as well?
(I just made the code compliant to the ifdef in the header ;-) )

Kind regards,

Remy