[U-Boot] [PATCH] Make the generic unaligned access code safe for unaligned access

Tom
2009-10-29T14:30:02Z

Remy Bohmer wrote:
> Hi,
>
> 2009/10/29 Stefan Roese <sr@denx.de>:
>> Hi Remy,
>>
>> On Wednesday 28 October 2009 22:13:38 Remy Bohmer wrote:
>>> The current generic code for handling unaligned access assumes that
>>> the processor can properly handle unaligned accesses itself.
>>> This is at least not the case for ARM, which results in runtime
>>> errors.
>>>
>>> Rewrite it such that it works for ARM as well.
>> I introduced this header some time ago for UBIFS support (for PowerPC).
>> As you may have noticed, it's a copy from the Linux version. And I
>
> Yep, I noticed that.
>
>> would like to keep it this way if possible.
>
> I understand that, but still the code in there is not _generic_, it
> might work on Linux since the data-abort trapcode is handling this
> exception that occurs on unaligned accesses...
>
>> Looking at the Linux ARM
>> version, the basic difference seems to be the header
>> "include/asm-arm/unaligned.h" which includes this file. The Linux
>> version of "unaligned.h" does *not* include "access_ok.h" at all. It
>> includes "le_byteshift.h" and "be_byteshift.h" instead. And I would
>> really like to keep this in sync with Linux if possible.
>
>> So why not do it this way (totally untested):

I see the patch has been reposted.
Has it been tested ?

Tom