public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] POST: Remove duplicated post_hotkey_pressed() functions
Date: Wed, 25 Nov 2009 11:05:27 +0100	[thread overview]
Message-ID: <200911251105.27213.sr@denx.de> (raw)
In-Reply-To: <20091124223502.360F2A87D0A@gemini.denx.de>

Hi Wolfgang,

On Tuesday 24 November 2009 23:35:02 Wolfgang Denk wrote:
> Hm... but the implementations were actually different. Some boards
> 
> used ctrlc() so they would catch a (prebably previously pressed) ^C:
> > --- a/board/amcc/katmai/katmai.c
> > +++ b/board/amcc/katmai/katmai.c
> 
> ..
> 
> > -int post_hotkeys_pressed(void)
> > -{
> > -	return (ctrlc());
> > -}
> > -#endif
> 
> ..while others unconditionally return 09, without checking for ^C:
> > --- a/board/amcc/kilauea/kilauea.c
> > +++ b/board/amcc/kilauea/kilauea.c
> 
> ..
> 
> > -int post_hotkeys_pressed(void)
> > -{
> > -	return 0;	/* No hotkeys supported */
> > -}
> 
> Are you sure the suggested change does not change the behavious on any
> of these boards?

Yes. The boards with this ctrlc() checking don't have POST support enabled at 
all (e.g. Katmai). So the behaviour is not changed.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

  reply	other threads:[~2009-11-25 10:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-30 12:38 [U-Boot] [PATCH] POST: Remove duplicated post_hotkey_pressed() functions Stefan Roese
2009-11-24 22:35 ` Wolfgang Denk
2009-11-25 10:05   ` Stefan Roese [this message]
2009-12-02 21:36 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200911251105.27213.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox