From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Wed, 25 Nov 2009 11:05:27 +0100
Subject: [U-Boot] [PATCH] POST: Remove duplicated post_hotkey_pressed()
	functions
In-Reply-To: <20091124223502.360F2A87D0A@gemini.denx.de>
References: <1256906335-6477-1-git-send-email-sr@denx.de>
	<20091124223502.360F2A87D0A@gemini.denx.de>
Message-ID: <200911251105.27213.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Wolfgang,

On Tuesday 24 November 2009 23:35:02 Wolfgang Denk wrote:
> Hm... but the implementations were actually different. Some boards
> 
> used ctrlc() so they would catch a (prebably previously pressed) ^C:
> > --- a/board/amcc/katmai/katmai.c
> > +++ b/board/amcc/katmai/katmai.c
> 
> ..
> 
> > -int post_hotkeys_pressed(void)
> > -{
> > -	return (ctrlc());
> > -}
> > -#endif
> 
> ..while others unconditionally return 09, without checking for ^C:
> > --- a/board/amcc/kilauea/kilauea.c
> > +++ b/board/amcc/kilauea/kilauea.c
> 
> ..
> 
> > -int post_hotkeys_pressed(void)
> > -{
> > -	return 0;	/* No hotkeys supported */
> > -}
> 
> Are you sure the suggested change does not change the behavious on any
> of these boards?

Yes. The boards with this ctrlc() checking don't have POST support enabled at 
all (e.g. Katmai). So the behaviour is not changed.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de