From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alessandro Rubini Date: Wed, 25 Nov 2009 16:23:26 +0100 Subject: [U-Boot] [PATCH 8/8] nhk8815: added lcd support In-Reply-To: <20091122225321.BF829E34A27@gemini.denx.de> References: <20091122225321.BF829E34A27@gemini.denx.de> <109a8c9f77c98641a8a02c4346cd2c7d2cc6794f.1255086085.git.rubini@unip v.it> Message-ID: <20091125152326.GA30679@mail.gnudd.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de I'm almost done with the requested changes on this patch set, will post V2 this evening after re-running ./makeall as needed. I've a question, though: >> +extern int nhk8815_backlight_on(void); /* in ./lcd.c */ > > Please move prototype decl;arations to some header file. Unfortunately, there is no suitable file. It's just that I split code related to different drivers in different files, for better housekeeping. These two are called nhk8815-something as they are board-specific anyways. Should I create a local header file in this same board directory, with just the two prototypes? Or "ifndef __ASSEMBLY__ in the board config file is better? I'd better ask first to avoid a V3 just for this detail. Thanks /alessandro