[U-Boot] [PATCH] ppc: transform init_sequence into a function.

Graeme Russ
2010-12-06T23:04:23Z

On Tue, Dec 7, 2010 at 9:49 AM, Scott Wood <scottwood@freescale.com> wrote:
> On Tue, 7 Dec 2010 09:36:40 +1100
> Graeme Russ <graeme.russ@gmail.com> wrote:
>
>> On Tue, Dec 7, 2010 at 8:33 AM, Scott Wood <scottwood@freescale.com> wrote:
>> > I think it's easier with the function pointers -- if you want to debug
>> > a hang in that phase of the boot, just have the loop print the address
>> > of each function before it calls it.
>>
>> I agree, but you can't print the address before you have console output.
>
> It's usually not too hard to hack something together, even if it's too
> early for normal console output -- but I'd expect most problems to be
> either before the initialization list, or after the console is working.
>
>> I notice that console_init_f() can be up to 13th in the list of initialisation
>> functions - How often is that the case? There seems to be a lot of SDRAM
>> initialisation prior to getting console output which, to me, seems a little
>> strange - surely console output can be achieved earlier (even if it is using
>> a hard-coded baud rate)
>
> I don't see "a lot of SDRAM initialization" -- there's
> adjust_sdram_tbs_8xx, but that's really just setting up a couple clock
> registers (and it's only for 8xx). ?It's not the real SDRAM init.

And sdram_adjust_866() - True, not 'a lot'

But then there is dpram_init() as well which does not look like a
pre-req to console

Regards,

Graeme