[U-Boot] [PATCH] ppc: transform init_sequence into a function.

Wolfgang Denk
2010-12-06T23:09:53Z

Dear Graeme Russ,

In message <AANLkTikH3O9gZWsuEaKn-BK+8iAhUeRyk2iL+ezZz-y1@mail.gmail.com> you wrote:
>
> I agree, but you can't print the address before you have console output. I
> notice that console_init_f() can be up to 13th in the list of initialisation
> functions - How often is that the case? There seems to be a lot of SDRAM
> initialisation prior to getting console output which, to me, seems a little

No, this is only on broken system that don't play by the rules. See
http://www.denx.de/wiki/view/U-Boot/DesignPrinciples#6_Keep_it_Debuggable

Board / architecture maintainers that ignore the design principles
deserve some punishment ;-)

> I don't think it will be long before board_init_f() gets unified into common
> code and I would hate to see this uglyness spread to all arches.

Full ACK.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When a woman marries again it is because she detested her first hus-
band. When a man marries again, it is because he adored his first
wife. -- Oscar Wilde