[U-Boot] [PATCH] ppc: transform init_sequence into a function.

Wolfgang Denk
2009-11-30T21:02:44Z

Dear Joakim Tjernlund,

In message <OF9F9C7491.8E6AB1CE-ONC125767E.00448FDA-C125767E.00453C54@transmode.se> you wrote:
> Wolfgang Denk <wd@denx.de> wrote on 27/11/2009 21:18:28:
> > I am not convinced yet that the new code is actually an improvement.
> > Changing the array of pointers into a list of function calls does not
> > solve any of the real issues we have with the init seuqnece - like
> > that some board need the PCI initialization early, and others later,
> > etc.
>
> Somewhat offtopic, but you could add a few weak empty dummy functions
> at strategic places in the board_X funcs. Any board that
> needs some extra init sequence could define the appropriate function
> which will replace the weak one.

Yes. And all boards that don't need it will suffer from the increased
memory footprint.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There's an old story about the person who wished his computer were as
easy to use as his telephone. That wish has come true, since I no
longer know how to use my telephone.