public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix computation in nand_util.c:get_len_incl_bad
Date: Tue, 1 Dec 2009 17:55:10 -0600	[thread overview]
Message-ID: <20091201235510.GA19547@loki.buserror.net> (raw)
In-Reply-To: <1259672755-929-1-git-send-email-daniel.hobi@schmid-telecom.ch>

On Tue, Dec 01, 2009 at 02:05:55PM +0100, Daniel Hobi wrote:
> Depending on offset, flash size and the number of bad blocks,
> get_len_incl_bad may return a too small value which may lead to:
> 
> 1) If there are no bad blocks, nand_{read,write}_skip_bad chooses the
> bad block aware read/write code. This may hurt performance, but does
> not have any adverse effects.
> 
> 2) If there are bad blocks, the nand_{read,write}_skip_bad may choose
> the bad block unaware read/write code (if len_incl_bad == *length)
> which leads to corrupted data.

It could also lead to the rejection of accesses near the end of flash.

> Signed-off-by: Daniel Hobi <daniel.hobi@schmid-telecom.ch>
> ---
> @Scott: please review
> @Wolfgang: please consider for 2009.11

Applied to next.  I think it's too late for 2009.12, since it's supposed to
be released tomorrow according to http://www.denx.de/wiki/U-Boot/ReleaseCycle,
and it's not a regression from the previous version.

-Scott

  reply	other threads:[~2009-12-01 23:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-01 13:05 [U-Boot] [PATCH] Fix computation in nand_util.c:get_len_incl_bad Daniel Hobi
2009-12-01 23:55 ` Scott Wood [this message]
2009-12-05  0:44   ` Wolfgang Denk
2009-12-07 21:38 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091201235510.GA19547@loki.buserror.net \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox